-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test images: Adds sync.exe to Windows agnhost images #103976
test images: Adds sync.exe to Windows agnhost images #103976
Conversation
@claudiubelu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b257ece
to
1cf12f1
Compare
build/dependencies.yaml
Outdated
@@ -18,7 +18,7 @@ dependencies: | |||
|
|||
# agnhost: bump this one first | |||
- name: "agnhost" | |||
version: "2.32" | |||
version: "2.33" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below these lines it says "agnhost: dependents" and it still has v2.32, do we need to update that too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We update that later. First, we need to merge this PR, so the postsubmit jobs will build agnhost:2.33, then we promote the image from staging, then we send a PR that updates test/utils/image/manifest.go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks
it'd also be great if the README inside test/images/agnhost is updated |
Done |
1cf12f1
to
135d83b
Compare
Although I'm not an approver in build/OWNERS /lgtm |
Needs milestone. /cc @mkumatag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
We can get sync.exe from coreutils.
135d83b
to
d9f2268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/milestone v1.23
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, mkumatag, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig windows
/sig testing
/priority important-soon
What this PR does / why we need it:
We can get sync.exe from coreutils.
Which issue(s) this PR fixes:
Fixes #101172
Special notes for your reviewer:
Built
claudiubelu/agnhost:2.33
with this PR:Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: