Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test images: Adds sync.exe to Windows agnhost images #103976

Merged

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jul 28, 2021

What type of PR is this?

/kind feature

/sig windows
/sig testing

/priority important-soon

What this PR does / why we need it:

We can get sync.exe from coreutils.

Which issue(s) this PR fixes:

Fixes #101172

Special notes for your reviewer:

Built claudiubelu/agnhost:2.33 with this PR:

docker run --rm --entrypoint sync.exe claudiubelu/agnhost:2.33 --help
Unable to find image 'claudiubelu/agnhost:2.33' locally
2.33: Pulling from claudiubelu/agnhost
ba17af31b927: Pull complete
...
7f46c3c5afe7: Pull complete
Digest: sha256:0e5869ae59ad8609b96d1e750205be6cb190fc59ee4ee648635f27d8dbd808fd
Status: Downloaded newer image for claudiubelu/agnhost:2.33
Usage: sync.exe [OPTION] [FILE]...
Synchronize cached writes to persistent storage

If one or more files are specified, sync only them,
or their containing file systems.

  -d, --data             sync only file data, no unneeded metadata
  -f, --file-system      sync the file systems that contain the files
      --help     display this help and exit
      --version  output version information and exit

GNU coreutils online help: <https://www.gnu.org/software/coreutils/>
Full documentation <https://www.gnu.org/software/coreutils/sync>
or available locally via: info '(coreutils) sync invocation'

This is an UNSUPPORTED, UNTESTED, EXPERIMENTAL build of GNU coreutils.
USE AT YOUR OWN RISK.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test labels Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@claudiubelu claudiubelu force-pushed the test-images/agnhost-adds-sync-exe branch from b257ece to 1cf12f1 Compare July 28, 2021 13:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2021
@@ -18,7 +18,7 @@ dependencies:

# agnhost: bump this one first
- name: "agnhost"
version: "2.32"
version: "2.33"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below these lines it says "agnhost: dependents" and it still has v2.32, do we need to update that too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We update that later. First, we need to merge this PR, so the postsubmit jobs will build agnhost:2.33, then we promote the image from staging, then we send a PR that updates test/utils/image/manifest.go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks

@mauriciopoppe
Copy link
Member

it'd also be great if the README inside test/images/agnhost is updated

@claudiubelu
Copy link
Contributor Author

it'd also be great if the README inside test/images/agnhost is updated

Done

@claudiubelu claudiubelu force-pushed the test-images/agnhost-adds-sync-exe branch from 1cf12f1 to 135d83b Compare July 29, 2021 08:37
@mauriciopoppe
Copy link
Member

mauriciopoppe commented Jul 29, 2021

Although I'm not an approver in build/OWNERS

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@claudiubelu
Copy link
Contributor Author

Needs milestone.

/cc @mkumatag

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@marosset marosset added this to In Review (v1.23) in SIG-Windows Aug 6, 2021
We can get sync.exe from coreutils.
@claudiubelu claudiubelu force-pushed the test-images/agnhost-adds-sync-exe branch from 135d83b to d9f2268 Compare August 11, 2021 11:45
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, mkumatag, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 81dca3d into kubernetes:master Aug 12, 2021
SIG-Windows automation moved this from In Review (v1.23) to Done (v1.23) Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG-Windows
  
Done (v1.23)
Development

Successfully merging this pull request may close these issues.

Add sync to the windows node for storage E2E tests
5 participants