-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release note block to cherry-pick script #103987
Add release note block to cherry-pick script #103987
Conversation
@ehashman: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority backlog |
I think this approach is not a correct one. The script should rather use the rel note of the PR that is being backoported. Have in mind that the script can backport n PRs at once. Also I think that there is already a machinery that can collect release notes from backports without rel notes - the changelog of the patch releases should be generated via automation. So I am wondering even why we need such change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9272ef3
to
fec260d
Compare
Because currently if you don't specify a release note on backport PRs, the merge is blocked: #103977 (comment) #103977 (comment) |
flake #100788 |
/lgtm |
/ok-to-test |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind cleanup
/sig testing
What this PR does / why we need it:
Cherry-pick script always is missing a release-note block, this adds one to fill in.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: