Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #103958: Set idle and readheader timeouts #103991

Merged
merged 1 commit into from Aug 16, 2021
Merged

Automated cherry pick of #103958: Set idle and readheader timeouts #103991

merged 1 commit into from Aug 16, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 28, 2021

Cherry pick of #103958 on release-1.19.

#103958: Set idle and readheader timeouts

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 28, 2021

/hold for #103958

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 28, 2021
@wojtek-t
Copy link
Member

/retest

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2021
@liggitt liggitt added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 29, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 2, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 2, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 2, 2021

/hold for signal in master post-merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Aug 2, 2021
@cpanato
Copy link
Member

cpanato commented Aug 10, 2021

from parent PR:
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 10, 2021
cpanato
cpanato approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 10, 2021
@cpanato
Copy link
Member

cpanato commented Aug 10, 2021

@liggitt I did not lift the hold because I don't know if there is anything pending, let me know if is ok to unhold

thanks!

@liggitt
Copy link
Member Author

liggitt commented Aug 10, 2021

looks like this missed the 1.19 patch deadline... since this is a long-standing issue, I don't know that it's critical to squeeze into 1.19 as an exception

/close

SIG Node PR Triage automation moved this from Waiting on Author to Done Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

looks like this missed the 1.19 patch deadline... since this is a long-standing issue, I don't know that it's critical to squeeze into 1.19 as an exception

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Aug 11, 2021

@liggitt it was approved before the deadline, if this is needed we can reopen and merge it. I asked because it has a hold and I was unsure if I can lift that.

@cpanato
Copy link
Member

cpanato commented Aug 11, 2021

@liggitt also we will have at least two more patch release for the 1.19, feel free to reopen this CP

@liggitt liggitt reopened this Aug 11, 2021
SIG Node PR Triage automation moved this from Done to Triage Aug 11, 2021
@cpanato
Copy link
Member

cpanato commented Aug 11, 2021

/hold just because we are running the patch releases for this month

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/hold cancel patch for 1.19 is done for this cycle

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

@liggitt i think you are the only one to lift the hold

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9cf0694 into kubernetes:release-1.19 Aug 16, 2021
SIG Node PR Triage automation moved this from Triage to Done Aug 16, 2021
@liggitt liggitt deleted the automated-cherry-pick-of-#103958-upstream-release-1.19 branch August 17, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jpbetz jpbetz Awaiting requested review from jpbetz

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@cpanato cpanato

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @wojtek-t @fedebongio @cpanato @k8s-ci-robot