-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cleanup of the package for event clocks #104212
Some cleanup of the package for event clocks #104212
Conversation
98c5482
to
1405681
Compare
/retest |
Rename from `clock` to `eventclock`. Simplify by removing the prohibition on an EventFunc suspending and resuming activity. Remove "EventClock" from names to avoid stuttering. Start to consolidate test code under fairqueuing/testing/.
1405681
to
80ca6a4
Compare
/retest |
/assign @liggitt |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Rename fairqueuing package
clock
toeventclock
because it is a specific extension of the existing clock abstraction package rather than a replacement.Simplify by removing the prohibition on an EventFunc waiting on time advancing.
Remove "EventClock" from names to avoid stuttering.
Start to consolidate test code under fairqueuing/testing/, because that was requested in #104002 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a (hopefully better) alternative to #104189 .
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: