Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.19][go1.15] Update to go1.15.15 #104216

Merged
merged 3 commits into from Aug 8, 2021
Merged

[1.19][go1.15] Update to go1.15.15 #104216

merged 3 commits into from Aug 8, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 7, 2021 •
edited

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update to Go 1.15.15 on release-1.19

Tracking issue: kubernetes/release#2196
Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1628235574145600

Which issue(s) this PR fixes:

/assign @dims @liggitt @justaugustus @saschagrunert @puerco
cc: @kubernetes/release-engineering

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes 1.19.x is now built using Go 1.15.15

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 7, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2021
@cpanato cpanato changed the title Automated cherry pick of #104215: Bump to golang 1.15.15 in test/** [1.19][go1.15] Update to go1.15.15 Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 7, 2021

/kind feature
/area dependency

/assign @dims @liggitt @justaugustus @saschagrunert @puerco
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 7, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 7, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2021
@cpanato cpanato mentioned this pull request Aug 7, 2021
Closed
29 tasks
@cpanato cpanato force-pushed the automated-cherry-pick-of-#104215-upstream-release-1.19 branch from 435a699 to 38a4fd4 Compare August 7, 2021 11:47
@cpanato
Bump to golang 1.15.15 in test/**
7ccb42f 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Bump to golang 1.15.15 in cluster/** and staging/**
20199f9 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Bump to golang 1.15.15 in build/**
f3b583e 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato cpanato force-pushed the automated-cherry-pick-of-#104215-upstream-release-1.19 branch from 38a4fd4 to f3b583e Compare August 7, 2021 11:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 7, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@dims
Copy link
Member

dims commented Aug 7, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2021
@liggitt
Copy link
Member

liggitt commented Aug 8, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2021
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 8, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 021e7c5 into kubernetes:release-1.19 Aug 8, 2021
@cpanato cpanato deleted the automated-cherry-pick-of-#104215-upstream-release-1.19 branch August 8, 2021 11:45
This was referenced Aug 8, 2021
Merged
Merged
@cpanato cpanato mentioned this pull request Sep 10, 2021
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan Awaiting requested review from hasheddan

@kawych kawych Awaiting requested review from kawych

Assignees

@dims dims

@justaugustus justaugustus

@saschagrunert saschagrunert

@liggitt liggitt

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cpanato @k8s-ci-robot @dims @liggitt @justaugustus @saschagrunert @puerco