remove unnecessary waits from watch conformance test #104224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic0eb4197ac4eeaf67a6d9c64c3f04a0d50bd5b03
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
release-note-none
|
This makes sense to speed up a test and we don't loose any signal. /lgtm /retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This test takes longer than it needs to. There are four unnecessary waits; this PR removes the unnecessary waits which wait for the absence of a watch event (but also preserves other waits which cannot be substituted). Obviously these waits will cause us to wait until the timeout completely elapses.
Later in the test, we actually _ do test_ for the output of watchB; if there had been any additional watch events, i.e. events which we did not expect, then the first check against the output of watchB would be false.
/sig api-machinery