Convert some GCE LB events to logs. #104362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
sig/network
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/triage accepted /assign @cheftako @andrewsykim |
k8s-ci-robot
added
triage/accepted
|
/retest |
|
/kind bug |
k8s-ci-robot
added
kind/bug
andrewsykim
reviewed
Aug 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, bowei, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events can be quite noisy. This PR is a bug fix because the event being emitted is not entirely correct - a different controller still processes the service, but the event gives the impression that processing is entirely skipped.
What type of PR is this?
What this PR does / why we need it:
This PR removes some of the GCE ILB event messages and adds log messages instead. These event messages can be noisy and not add much value to the end user.
This PR is a bug fix because the event being emitted is not entirely correct - a different controller still processes the service, but the event gives the impression that processing is entirely skipped.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: