Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PodSecurity] log nsPolicy evaluation for the request #104365

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Aug 14, 2021

Signed-off-by: jyz0309 45495947@qq.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

log nsPolicy evaluation for the request and fix a TODO.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 14, 2021
@k8s-ci-robot
Copy link
Contributor

@jyz0309: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Aug 14, 2021

/assign @tallclair PTAL if you have time~Thank a lot!😳

@liggitt
Copy link
Member

liggitt commented Aug 14, 2021

/assign @tallclair

@liggitt liggitt added this to In Review in SIG-Auth: PodSecurity via automation Aug 14, 2021
@enj enj added this to Needs Triage in SIG Auth Old Aug 17, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Aug 20, 2021

@tallclair fix comment, PTAL again~

@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 18, 2021

sig/auth

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2021
Signed-off-by: jyz0309 <45495947@qq.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2021
Signed-off-by: jyz0309 <45495947@qq.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2021
Signed-off-by: jyz0309 <45495947@qq.com>
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

SIG Auth Old automation moved this from Needs Triage to In Progress Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 30, 2021

/retest-required

@k8s-ci-robot
Copy link
Contributor

@jyz0309: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 30, 2021

It seems that rerun the fail test need a ok-to-test label :) @tallclair

@pacoxu
Copy link
Member

pacoxu commented Sep 30, 2021

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 30, 2021

It has the sig/auth labels, but still have not removed the do-not-merge/needs-sig label, so weird :) @k8s-ci-robot

@pacoxu
Copy link
Member

pacoxu commented Sep 30, 2021

/remove-sig auth

@k8s-ci-robot k8s-ci-robot removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Sep 30, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 30, 2021

It has the sig/auth labels, but still have not removed the do-not-merge/needs-sig label, so weird :) @k8s-ci-robot

It's a robot problem. It can be solved by remove sig + add sig again.

@pacoxu
Copy link
Member

pacoxu commented Sep 30, 2021

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 30, 2021

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 3874675 into kubernetes:master Sep 30, 2021
SIG Auth Old automation moved this from In Progress to Closed / Done Sep 30, 2021
SIG-Auth: PodSecurity automation moved this from In Review to Done (1.23, Beta) Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
SIG-Auth: PodSecurity
Done (1.23, Beta)
SIG Auth Old
Closed / Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants