Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github forms for issue templates #104468

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Use github forms for issue templates #104468

merged 1 commit into from
Oct 7, 2021

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 20, 2021

You can see the results here: https://github.com/thockin/kubernetes/issues/new/choose

Sadly it doesn't seem to work for PRs.

/kind cleanup

NONE

@thockin thockin added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 20, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2021
@aojea
Copy link
Member

aojea commented Aug 24, 2021

lgtm
/assign @mrbobbytables

@mrbobbytables
Copy link
Member

Ah...sorry, this slipped through the cracks for me. Will review shortly 👍

mrbobbytables
mrbobbytables requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This has actually been on my todo for a bit, but fell into the realm of E_TOO_MANY_THINGS.

I have a few small suggestions, and after that it should be good to go :)

.github/ISSUE_TEMPLATE/bug-report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/flaking-test.yaml Show resolved Hide resolved
@mrbobbytables
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 17, 2021
RinkiyaKeDad
RinkiyaKeDad reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@RinkiyaKeDad RinkiyaKeDad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes based on #105190 🙂

Also, it won't be possible to use prow commands from the form entries right? So for example, if someone entered /sig node in the form, would prow be able to apply the correct label?

.github/ISSUE_TEMPLATE/failing-test.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/flaking-test.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2021
@thockin thockin force-pushed the master branch 4 times, most recently from 15985e3 to 4fe2fdc Compare October 5, 2021 16:53
thockin
thockin commented Oct 5, 2021
View reviewed changes
Copy link
Member Author

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

.github/ISSUE_TEMPLATE/bug-report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/failing-test.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/flaking-test.yaml Show resolved Hide resolved
@mrbobbytables
Copy link
Member

Also, it won't be possible to use prow commands from the form entries right? So for example, if someone entered /sig node in the form, would prow be able to apply the correct label?

They will come through, when posted its all markdown and prow responds to the content of the message

@cblecker
Copy link
Member

cblecker commented Oct 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@mrbobbytables
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d7f74ca into kubernetes:master Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 7, 2021
pohly added a commit to pohly/community that referenced this pull request Mar 24, 2022
@pohly
flaky-tests.md: update template in link
554bbdf 
This changed from .md to .yaml in
kubernetes/kubernetes#104468.
@pohly pohly mentioned this pull request Mar 24, 2022
Merged
@furkatgofurov7 furkatgofurov7 mentioned this pull request Dec 19, 2022
Merged
@sftim sftim mentioned this pull request Jan 6, 2023
Closed
This was referenced Dec 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinkiyaKeDad RinkiyaKeDad RinkiyaKeDad left review comments

@mrbobbytables mrbobbytables mrbobbytables requested changes

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@cblecker cblecker

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thockin @aojea @mrbobbytables @cblecker @k8s-ci-robot @RinkiyaKeDad