Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_node: Properly check for DynamicKubeletConfig #104481

Merged
merged 1 commit into from
Nov 4, 2021
Merged

e2e_node: Properly check for DynamicKubeletConfig #104481

merged 1 commit into from
Nov 4, 2021

Conversation

AlexeyPerevalov
Copy link
Contributor

@AlexeyPerevalov AlexeyPerevalov commented Aug 20, 2021 •
edited

Even DynamicKubeletConfig is deprecated it still used in e2e_node test.
The bug is hidden by forcibly enabled option
TEST_ARGS='--feature-gates=DynamicKubeletConfig=true'
if this option is not enabled setKubeletConfiguration tries to set
kubelet config via apiserver interface and failed with timeout.

This default value was changed in #64457
when DynamicKubeletConfig was enabled by default, now it is disabled by default.

Signed-off-by: Alexey Perevalov alexey.perevalov@huawei.com

/kind failing-test

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@AlexeyPerevalov
e2e_node: Check for DynamicKubeletConfig properly
461d8f5 
Even DynamicKubeletConfig is deprecated it still used in e2e_node test.
The bug is hidden by forcibly enabled option
TEST_ARGS='--feature-gates=DynamicKubeletConfig=true'
if this option is not enabled setKubeletConfiguration tries to set
kubelet config via apiserver interface and failed with timeout.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 20, 2021
@AlexeyPerevalov AlexeyPerevalov changed the title e2e_node: Properly check for DynamicKubeletConfig properly e2e_node: Properly check for DynamicKubeletConfig Aug 20, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 20, 2021
@matthyx
Copy link
Contributor

matthyx commented Aug 20, 2021

/triage accepted
/priority important-soon
/kind failing-test
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@matthyx
Copy link
Contributor

matthyx commented Aug 20, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 20, 2021
@matthyx
Copy link
Contributor

matthyx commented Aug 20, 2021

Hmm, maybe you have to check the failing test...
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@AlexeyPerevalov
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Sep 1, 2021
@pacoxu pacoxu added this to Waiting on Author in SIG Node PR Triage Sep 3, 2021
@pacoxu pacoxu removed this from Waiting on Author in SIG Node PR Triage Sep 3, 2021
@matthyx
Copy link
Contributor

matthyx commented Sep 15, 2021

@AlexeyPerevalov are you still looking at this?

@matthyx matthyx moved this from PRs - Needs Reviewer to PRs Waiting on Author in SIG Node CI/Test Board Sep 15, 2021
@AlexeyPerevalov
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial

@SergeyKanzhelev
Copy link
Member

/assign

@SergeyKanzhelev SergeyKanzhelev moved this from PRs Waiting on Author to PRs - Needs Reviewer in SIG Node CI/Test Board Sep 22, 2021
@ffromani
Copy link
Contributor

ffromani commented Oct 1, 2021

/test pull-kubernetes-node-kubelet-serial
good catch!
I'm fairly convinced this change is correct and we are "just" hitting new flakes in the serial lane.

This was referenced Oct 1, 2021
Merged
Merged
@AlexeyPerevalov
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2021
@SergeyKanzhelev
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@AlexeyPerevalov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial 461d8f5 link false /test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SergeyKanzhelev
Copy link
Member

failed tests are failing continuously https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-serial. Skipping

/skip

@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexeyPerevalov, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2021
@ehashman
Copy link
Member

ehashman commented Nov 4, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@ehashman ehashman moved this from PRs - Needs Reviewer to Done in SIG Node CI/Test Board Nov 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 27d3a9e into kubernetes:master Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 4, 2021
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@SergeyKanzhelev SergeyKanzhelev

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexeyPerevalov @matthyx @SergeyKanzhelev @ffromani @k8s-ci-robot @ehashman