Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test for cronjob with controllerv2 #104570

Merged
merged 1 commit into from
Sep 2, 2021
Merged

integration test for cronjob with controllerv2 #104570

merged 1 commit into from
Sep 2, 2021

Conversation

RyanAoh
Copy link
Member

@RyanAoh RyanAoh commented Aug 25, 2021

What type of PR is this?

/kind flake

What this PR does / why we need it:

CronJobControllerV2 is GA in 1.22. But There are no integration tests for it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @RyanAoh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 25, 2021
neolit123
neolit123 reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try asking for a reviewer in the #sig-apps channel of k8s slack.

test/integration/cronjob/cronjob_controllerv2_test.go Outdated
@@ -0,0 +1,80 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should be current year

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. PTAL.
Thanks.

@neolit123
Copy link
Member

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Aug 25, 2021
@RyanAoh RyanAoh force-pushed the cronjob_dev branch 2 times, most recently from 7f3c26a to 1277653 Compare August 25, 2021 12:53
@RyanAoh RyanAoh requested a review from neolit123 August 25, 2021 17:41
@neolit123
Copy link
Member

neolit123 commented Aug 25, 2021 •
edited

Try asking for a reviewer in the #sig-apps channel of k8s slack.

ideally this should be reviewed by the relevant code / package owners.

https://github.com/kubernetes/kubernetes/tree/12776530b21fc73b4944b963c00497acc0feeab9/test/integration/cronjob doesn't have an OWNERS file, but CronJobs are owned by SIG Apps.

@RyanAoh
Copy link
Member Author

RyanAoh commented Aug 25, 2021

Try asking for a reviewer in the #sig-apps channel of k8s slack.

ideally this should be reviewed by the relevant code / package owners.

https://github.com/kubernetes/kubernetes/tree/12776530b21fc73b4944b963c00497acc0feeab9/test/integration/cronjob doesn't have an OWNERS file, but CronJobs are owned by SIG Apps.

Thanks @neolit123 . I've sent a message in the #sig-apps channel of k8s slack for asking someone to review this.

@RyanAoh
Copy link
Member Author

RyanAoh commented Aug 26, 2021

/cc @alaypatel07

@RyanAoh
Copy link
Member Author

RyanAoh commented Aug 26, 2021

/cc @soltysh

@pacoxu
Copy link
Member

pacoxu commented Aug 30, 2021

/ok-to-test
/cc mengjiao-liu

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2021
@mengjiao-liu
Copy link
Member

The test code looks fine, but CronJobControllerV2 has reached GA and according to this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable#release-122 , the old controller needs to be cleaned up.

Does the cronjob integration test code still need to keep the old controller? Can we just switch parts of the integration test code from the old controller to the new CronJobControllerV2 controller? @soltysh

@soltysh
Copy link
Contributor

soltysh commented Aug 31, 2021

Does the cronjob integration test code still need to keep the old controller? Can we just switch parts of the integration test code from the old controller to the new CronJobControllerV2 controller? @soltysh

Yeah, it doesn't make sense to add additional controller. We rather need to switch the existing test to use the new controller instead.

soltysh
soltysh requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2021
@RyanAoh RyanAoh changed the title add integration tests for cronjob with controllerv2 integration test for cronjob with controllerv2 Aug 31, 2021
@RyanAoh
Copy link
Member Author

RyanAoh commented Aug 31, 2021

Updated. I switched the existing test to use the new controller.
PTAL. @soltysh

@RyanAoh RyanAoh requested a review from soltysh August 31, 2021 13:26
@RyanAoh
Copy link
Member Author

RyanAoh commented Aug 31, 2021

/retest

soltysh
soltysh approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 2, 2021

/triage accept
/priority backlog

@k8s-ci-robot
Copy link
Contributor

@soltysh: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept
/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RyanAoh, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 2, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8d707e5 into kubernetes:master Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 2, 2021
@RyanAoh RyanAoh mentioned this pull request Sep 23, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RyanAoh @k8s-ci-robot @neolit123 @pacoxu @mengjiao-liu @soltysh