skip hack/tools/vendor folder

[aojea]

The makefiles scripts create a variable with all the go files
that are part of the Kubernetes source tree, including staging.

As today, this variable has a size of < 100kb

wc .make/all_go_dirs.mk
2326 2326 98905 .make/all_go_dirs.mk

This variable is passed as argument in the Makefiles, where it
is expanded. In Linux, there is a limit to the max size of
the arguments MAX_ARG_STRLEN.

If the arguments go above 128k, (depends on the kernel, by default #define MAX_ARG_STRLEN (PAGE_SIZE * 32))
you get a nice:

execvp: /usr/bin/env: Argument list too long

If you, for whatever reason, do some go mod vendor inside the
hack/tools folder, these files will be added to the variable
and most probably you'll go above the limit and get that error.

Then, you'll learn a lot about Makefils, shell expansion, strace,
execpve, ARG_MAX and MAX_ARG_STRLEN,until you realize what is
the real problem :).

/kind cleanup

NONE

How to reproduce it

$ cd hack/tools/
$ go mod vendor
$ git status
nothing to commit, working tree clean
$ cd -
$ make
make[1]: execvp: /usr/bin/env: Argument list too long
$ grep hack/tools/vendor .make/all_go_dirs.mk  | wc
    575     575   32739

Special notes

I know that nobody should vendor anything in that hack/tools/ folder, and I did it only to experiment with some things, but the fact that make clean don't delete the folder and git status doesn't report nothing made me spend more than 3 hours with this 🙃

[k8s-ci-robot]

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/assign @BenTheElder @thockin

[thockin]

How about this instead:

   find -H .                      \
        \(                         \
        -not \(                    \
            \(                     \
                -name '_*' -o      \
                -name '.[^.]*' -o  \
                \(                 \
                  -name 'vendor'   \
                  -type d          \
                \)                 \
            \) -prune              \
        \)                         \
        \)                         \

That will exclude ALL vendor directories, wherever they might pop up

[aojea]

I wanted to do that but I was not confident

[aojea]

is there any conflict with staging?

[thockin]

Thanks!

/lgtm
/approve
/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/sig testing