-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeMetrics, PodMetrics: Add doc for metav1.ObjectMeta #104627
NodeMetrics, PodMetrics: Add doc for metav1.ObjectMeta #104627
Conversation
Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
Welcome @arajkumar! |
Hi @arajkumar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/test |
@arajkumar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig instrumentation |
/retest |
/lgtm |
/assign @serathius |
LGTM, leaving it to API reviewer. |
/assign @ehashman |
/approve doc-change only, making it consistent with other types |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arajkumar, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds documentation for
metav1.ObjectMeta
field in NodeMetrics & PodMetrics types.Which issue(s) this PR fixes:
Fixes #104707
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: