-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in files which are used for generating OpenAPI #104747
Conversation
Hi @invidian. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
6fd33a7
to
e4300ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
e4300ed
to
5389293
Compare
There are still some files with those typos, but I'm not sure if they should be fixed as well: $ git grep -E '(fileystem|assigment|coersion)' | cut -d: -f1
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/testdata/swagger.json
staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
staging/src/k8s.io/kubectl/testdata/openapi/swagger.json
staging/src/k8s.io/kubectl/testdata/openapi/swagger.json
vendor/sigs.k8s.io/kustomize/api/krusty/kustomizer.go
vendor/sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi/v1204/swagger.json
vendor/sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi/v1204/swagger.json I guess remaining artifacts and testdata in EDIT: Opened kubernetes-sigs/kustomize#4169 for kustomize. |
Part of kubernetes/kubernetes#104747. Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
/test check-dependency-stats |
/lgtm |
/assign @lavalamp |
/triage accepted |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, invidian, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Right now when projects use https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/test-adapter/generated/openapi/zz_generated.openapi.go, they inherit couple of typos, which will be detected by tools like
codespell
.This PR fixes those typos.
Does this PR introduce a user-facing change?