-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/common: check if docker buildx is available #104749
Conversation
@cpanato: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
build/common.sh
Outdated
@@ -395,6 +395,23 @@ function kube::build::build_image() { | |||
# $3 is the value to set the --pull flag for docker build; true by default | |||
# $4 is the set of --build-args for docker. | |||
function kube::build::docker_build() { | |||
"${DOCKER[@]}" buildx >/dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, i thought we added kube::util::ensure-docker-buildx
can you please look at reusing that?
[dims@dims-a01 08:18] ~/go/src/k8s.io/kubernetes ⟩ rg kube::util::ensure-docker-buildx
test/images/image-util.sh
117: kube::util::ensure-docker-buildx
build/lib/release.sh
219: kube::util::ensure-docker-buildx
hack/lib/util.sh
710:# kube::util::ensure-docker-buildx
713:function kube::util::ensure-docker-buildx {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that is handy :) thanks updated
PTAL @dims
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
/sig testing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you!! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
check if
docker buildx
is available when building the imagesI tested in Fedora/ubuntu and the newer docker installation the
buildx
is available by default.not sure if this is want we want, but opening for feedback
/assign @ehashman @BenTheElder @dims
Which issue(s) this PR fixes:
Fixes #102822
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: