-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shellcheck output streams #104783
Fix shellcheck output streams #104783
Conversation
Welcome @YuviGold! |
Hi @YuviGold. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig testing |
/ok-to-test |
e2e flaky test failed |
hack/verify-shellcheck.sh
Outdated
fi | ||
|
||
# print a message based on the result | ||
if [ $res -eq 0 ]; then | ||
echo 'Congratulations! All shell files are passing lint :-)' | ||
else | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm: this should be going to stderr still, not stdout?
this is still a diagnostic message, not program output.
else | ||
echo "Using shellcheck ${SHELLCHECK_VERSION} docker image." | ||
"${DOCKER}" run \ | ||
--rm -v "${KUBE_ROOT}:${KUBE_ROOT}" -w "${KUBE_ROOT}" \ | ||
"${SHELLCHECK_IMAGE}" \ | ||
shellcheck "${SHELLCHECK_OPTIONS[@]}" "${all_shell_scripts[@]}" || res=$? | ||
shellcheck "${SHELLCHECK_OPTIONS[@]}" "${all_shell_scripts[@]}" >&2 || res=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :-) 🎉
Resolves kubernetes#102975 shellcheck errors are printed to stdout by default, hence they need to be redirected to stderr in order to be well parsed for Junit representation by `juLog` function.
ecd6504
to
bcb5d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
🎉 thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
/kind failing-test
What this PR does / why we need it:
shellcheck
errors are printed to stdout by default, hence they need to be redirectedto stderr in order to be well parsed for Junit representation by
juLog
function.Which issue(s) this PR fixes:
Fixes #102975
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Now the generated Junit would have the correct failures in it to be shown later on by Spyglass: