-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comment of processorListener.requestedResyncPeriod
#104812
Fix comment of processorListener.requestedResyncPeriod
#104812
Conversation
Hi @astraw99. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astraw99, caesarxuchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig api-machinery |
/remove-label do-not-merge/needs-sig |
@astraw99: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@caesarxuchao Could you please help to remove label |
It's a bot bug. |
/sig api-machinery |
/test pull-kubernetes-unit |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
From the code:
kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go
Line 287 in eb72962
the
resyncCheckPeriod
andstarted
are fields ofsharedIndexInformer
, so this PRfix the comment of
processorListener.requestedResyncPeriod
to better the doc.Does this PR introduce a user-facing change?