Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG OWNERS #104826

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Update CHANGELOG OWNERS #104826

merged 1 commit into from
Sep 9, 2021

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Sep 7, 2021 •
edited

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Update CHANGELOG OWNERS

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

@cici37: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 7, 2021
@cici37
Copy link
Contributor Author

cici37 commented Sep 7, 2021

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • AuraSinis

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

AuraSinis was added as org member here:
https://github.com/kubernetes/org/pull/2957/files

@cici37
Copy link
Contributor Author

cici37 commented Sep 7, 2021

/cc @AuraSinis

@k8s-ci-robot
Copy link
Contributor

@cici37: GitHub didn't allow me to request PR reviews from the following users: AuraSinis.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @AuraSinis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cici37
Copy link
Contributor Author

cici37 commented Sep 8, 2021

/cc @Damans227 @parul5sahoo @sam-cogan

@Damans227
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@sam-cogan
Copy link

/lgtm

@pacoxu
Copy link
Member

pacoxu commented Sep 9, 2021

/verify-owners

@pacoxu
Copy link
Member

pacoxu commented Sep 9, 2021

@cici37 I think it is because AuraSinis has not accepted the invitation of kubernetes org.

Comment /verify-owners after @AuraSinis confirmed the invitation.

@cici37
Copy link
Contributor Author

cici37 commented Sep 9, 2021

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 9, 2021
@cici37
Copy link
Contributor Author

cici37 commented Sep 9, 2021

/test pull-kubernetes-e2e-kind

@cici37
Copy link
Contributor Author

cici37 commented Sep 9, 2021

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit 73453e4 into kubernetes:master Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@cici37 cici37 deleted the UpdateOWNERS branch November 16, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simcard0000 simcard0000 Awaiting requested review from simcard0000

@sladyn98 sladyn98 Awaiting requested review from sladyn98

@Damans227 Damans227 Awaiting requested review from Damans227

@parul5sahoo parul5sahoo Awaiting requested review from parul5sahoo

@sam-cogan sam-cogan Awaiting requested review from sam-cogan

Assignees

@sam-cogan sam-cogan

@parul5sahoo parul5sahoo

@Damans227 Damans227

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cici37 @k8s-ci-robot @Damans227 @sam-cogan @pacoxu @parul5sahoo