tag ginkgo tests affected by pdcsi migration for skipping #105052

leiyiz · 2021-09-15T19:50:49Z

What type of PR is this?

What this PR does / why we need it:

When we turn on CSIMigrationGCE, some prow tests (and unit tests) are going to fail due to their reliance on gcepd driver. we need to tag them with an appropriate tag so that we can skip them in release-blocking jobs and presubmits.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2021-09-15T19:50:57Z

Hi @leiyiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leiyiz · 2021-09-15T19:51:51Z

@mattcary
@msau42
@jpbetz

mattcary · 2021-09-15T20:18:29Z

/ok-to-test

test/e2e/apps/statefulset.go

leiyiz · 2021-09-15T23:22:27Z

/retest

MadhavJivrajani · 2021-09-20T17:09:12Z

/priority important-soon
/kind cleanup
/triage accepted

test/e2e/cloud/gcp/cluster_upgrade.go

msau42 · 2021-10-01T22:02:23Z

test/e2e/storage/mounted_volume_resize.go

@@ -43,7 +43,7 @@ import (
 	"k8s.io/kubernetes/test/e2e/storage/utils"
 )

-var _ = utils.SIGDescribe("Mounted volume expand", func() {
+var _ = utils.SIGDescribe("Mounted volume expand [Feature:StorageProviderGCEPD]", func() {


@gnufied do we still need these tests or do the testsuite tests cover it? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/volume_expand.go

volume expand tests are also covered in pdcsi migration tests
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/run-k8s-integration-ci.sh#L32

Yes, what I mean is are these tests in mounted_volume_resize still needed or do we have equivalent test cases in testsuites/volume_expand.go

I think this test in mounted_volume_resize will also run due to focus [V|v]olume\sexpand

This e2e exercises a test which is not covered by test suite. I think we had some bug where if while volume is mounted and you quickly deleted the pod and recreated it (where global mount does not have chance to be removed), resize won't work. This e2e exercises that scenario.

Looking at this test case, I don't see anything that prevents the test from being imported into testsuites/volume_expand.go. Can you file a bug to track moving this test over? For now I think adding the tag to it is fine, but we'll want to move the test and remove the tag before 1.23 code freeze.

no problem. #105581

test/e2e/storage/pd.go

test/e2e/storage/persistent_volumes.go

msau42 · 2021-10-08T22:59:05Z

Can you also open an issue to track the upgrade test issue?

msau42 · 2021-10-08T22:59:08Z

/approve

k8s-ci-robot · 2021-10-08T23:02:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…rageclass check for statefulset and upgrade tests

leiyiz · 2021-10-11T00:49:03Z

Can you also open an issue to track the upgrade test issue?

no problem #105595

mattcary · 2021-10-11T17:51:33Z

/lgtm

k8s-ci-robot · 2021-10-11T19:01:52Z

@leiyiz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-kubelet-serial	b6943f87915fe1c9fb4427db75b7f70eae2e065d	link	`/test pull-kubernetes-node-kubelet-serial`
pull-kubernetes-node-kubelet-serial-containerd	b6943f87915fe1c9fb4427db75b7f70eae2e065d	link	`/test pull-kubernetes-node-kubelet-serial-containerd`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

leiyiz · 2021-10-11T19:08:18Z

/retest

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Sep 15, 2021

k8s-ci-robot requested review from andrewsykim and justinsb September 15, 2021 19:51

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2021

mattcary reviewed Sep 15, 2021

View reviewed changes

test/e2e/apps/statefulset.go Outdated Show resolved Hide resolved

SergeyKanzhelev added this to Triage in SIG Node CI/Test Board Sep 16, 2021

SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Sep 16, 2021

ehashman added this to Triage in SIG Node PR Triage Sep 20, 2021

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 30, 2021

leiyiz force-pushed the skip-storage-test branch from cd08864 to 178618f Compare September 30, 2021 23:34

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2021

leiyiz requested a review from msau42 October 1, 2021 18:43

msau42 reviewed Oct 1, 2021

View reviewed changes

leiyiz force-pushed the skip-storage-test branch 3 times, most recently from 8d84abe to d919128 Compare October 8, 2021 18:29

mattcary reviewed Oct 8, 2021

View reviewed changes

test/e2e/storage/persistent_volumes.go Show resolved Hide resolved

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021

leiyiz mentioned this pull request Oct 8, 2021

Move test cases from mounted_volume_resize into testsuites/volume_expand.go #105581

Closed

tag ginkgo tests affected by pdcsi migration for skipping and add sto…

822cc33

…rageclass check for statefulset and upgrade tests

leiyiz force-pushed the skip-storage-test branch from d919128 to 822cc33 Compare October 9, 2021 17:34

leiyiz mentioned this pull request Oct 11, 2021

Granularly skip storage test cases in upgrade testsuite #105595

Closed

k8s-ci-robot assigned mattcary Oct 11, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021

k8s-ci-robot merged commit f83b16d into kubernetes:master Oct 11, 2021

SIG Node CI/Test Board automation moved this from Archive-it to Done Oct 11, 2021

k8s-ci-robot added this to the v1.23 milestone Oct 11, 2021

leiyiz mentioned this pull request Nov 22, 2021

run test jobs / gce-pd tests that're skipped in k/k due to CSIMigrationGCE kubernetes/cloud-provider-gcp#293

Closed

leiyiz mentioned this pull request Feb 10, 2022

REQUEST: New membership for leiyiz kubernetes/org#3246

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tag ginkgo tests affected by pdcsi migration for skipping #105052

tag ginkgo tests affected by pdcsi migration for skipping #105052

leiyiz commented Sep 15, 2021

k8s-ci-robot commented Sep 15, 2021

leiyiz commented Sep 15, 2021 •

edited

mattcary commented Sep 15, 2021

leiyiz commented Sep 15, 2021

MadhavJivrajani commented Sep 20, 2021

msau42 Oct 1, 2021

leiyiz Oct 1, 2021 •

edited

msau42 Oct 1, 2021

leiyiz Oct 4, 2021 •

edited

gnufied Oct 8, 2021

msau42 Oct 8, 2021

leiyiz Oct 8, 2021

msau42 commented Oct 8, 2021

msau42 commented Oct 8, 2021

k8s-ci-robot commented Oct 8, 2021

leiyiz commented Oct 11, 2021

mattcary commented Oct 11, 2021

k8s-ci-robot commented Oct 11, 2021 •

edited

leiyiz commented Oct 11, 2021

tag ginkgo tests affected by pdcsi migration for skipping #105052

tag ginkgo tests affected by pdcsi migration for skipping #105052

Conversation

leiyiz commented Sep 15, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Sep 15, 2021

leiyiz commented Sep 15, 2021 • edited

mattcary commented Sep 15, 2021

leiyiz commented Sep 15, 2021

MadhavJivrajani commented Sep 20, 2021

msau42 Oct 1, 2021

Choose a reason for hiding this comment

leiyiz Oct 1, 2021 • edited

Choose a reason for hiding this comment

msau42 Oct 1, 2021

Choose a reason for hiding this comment

leiyiz Oct 4, 2021 • edited

Choose a reason for hiding this comment

gnufied Oct 8, 2021

Choose a reason for hiding this comment

msau42 Oct 8, 2021

Choose a reason for hiding this comment

leiyiz Oct 8, 2021

Choose a reason for hiding this comment

msau42 commented Oct 8, 2021

msau42 commented Oct 8, 2021

k8s-ci-robot commented Oct 8, 2021

leiyiz commented Oct 11, 2021

mattcary commented Oct 11, 2021

k8s-ci-robot commented Oct 11, 2021 • edited

leiyiz commented Oct 11, 2021

leiyiz commented Sep 15, 2021 •

edited

leiyiz Oct 1, 2021 •

edited

leiyiz Oct 4, 2021 •

edited

k8s-ci-robot commented Oct 11, 2021 •

edited