Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dualstack): remove should have ipv4 and ipv6 node podCIDRs test #105079

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 16, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

What type of PR is this?

  • Removes should have ipv4 and ipv6 node podCIDRs tests for dual-stack.

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #104544

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

@aramase: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 16, 2021
@aramase
Copy link
Member Author

aramase commented Sep 16, 2021

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/test and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 16, 2021
@aramase
Copy link
Member Author

aramase commented Sep 16, 2021

/test pull-kubernetes-e2e-ipvs-azure-dualstack

@aramase aramase marked this pull request as ready for review September 16, 2021 19:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2021
@aramase
Copy link
Member Author

aramase commented Sep 16, 2021

/assign @aojea

@aojea
Copy link
Member

aojea commented Sep 16, 2021

/lgtm
/approve
Thanks, this will be covered by the hostNetwork tests, since hostNetwork pods inherit the IPs from the node

// because the pods will try to acquire the same port in the host.
// We run the test in serial, to avoid port conflicts.
ginkgo.It("should function for service endpoints using hostNetwork", func() {
config := e2enetwork.NewNetworkingTestConfig(f, e2enetwork.EnableDualStack, e2enetwork.UseHostNetwork, e2enetwork.EndpointsUseHostNetwork)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2f10e65 into kubernetes:master Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 17, 2021
@aramase aramase deleted the remove-dualstack-test branch September 17, 2021 00:28
ricky-rav added a commit to ricky-rav/ovn-kubernetes that referenced this pull request Jan 20, 2022
…ests

Test "should have ipv4 and ipv6 node podCIDRs" was removed from e2e tests in kubernetes 1.23 (kubernetes/kubernetes#105079), so no need to skip it.
ricky-rav added a commit to ricky-rav/ovn-kubernetes that referenced this pull request Jan 20, 2022
…ests

Test "should have ipv4 and ipv6 node podCIDRs" was removed from e2e tests in kubernetes 1.23 (kubernetes/kubernetes#105079), so no need to skip it.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
ricky-rav added a commit to ricky-rav/ovn-kubernetes that referenced this pull request Mar 22, 2022
…ests

Test "should have ipv4 and ipv6 node podCIDRs" was removed from e2e tests in kubernetes 1.23 (kubernetes/kubernetes#105079), so no need to skip it.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What do we want to do with the test "should have ipv4 and ipv6 node podCIDRs"
3 participants