Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting in CHANGELOGs #105086

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Improve formatting in CHANGELOGs #105086

merged 1 commit into from
Sep 23, 2021

Conversation

ialidzhikov
Copy link
Contributor

/sig release
/kind cleanup

Before:

Screenshot 2021-09-17 at 10 09 20

After:

Screenshot 2021-09-17 at 10 09 47

Does this PR introduce a user-facing change?

NONE

@ialidzhikov
Improve formatting in CHANGELOGs
080c4b4 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Sep 17, 2021
@ialidzhikov
Copy link
Contributor Author

/cc @pmmalinov01

@ialidzhikov
Copy link
Contributor Author

/cc @puerco

Damans227
Damans227 reviewed Sep 20, 2021
View reviewed changes
CHANGELOG/CHANGELOG-1.19.md

This vulnerability was reported by Fabricio Voznika and Mark Wolters of Google.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @cici37 Can you take a look at this one ? I am not sure about these new changes. Thanks!

@puerco
Copy link
Member

puerco commented Sep 20, 2021

It's OK @Damans227

The formatting issue comes from the original data file we got from the PSC/Security Response Committee. As this data is collected at release time and is never modified again, the changelog would maintain the wrong format unless we update it manually, like this.

/ok-to-test
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2021
@Damans227
Copy link

Got it, thanks @puerco

@puerco
Copy link
Member

puerco commented Sep 23, 2021 •
edited

Thank you @ialidzhikov !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9462ca2 into kubernetes:master Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damans227 Damans227 Damans227 left review comments

@pmmalinov01 pmmalinov01 Awaiting requested review from pmmalinov01

@puerco puerco Awaiting requested review from puerco

Assignees

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ialidzhikov @k8s-ci-robot @puerco @Damans227