Add tests kubelet default config #105116

shuheiktgw · 2021-09-18T06:30:28Z

What type of PR is this?

/sig node
/kind cleanup
/area test

What this PR does / why we need it:

I've added tests for pkg/kubelet/apis/config/v1beta1/defaults.go. Thank you for your review!

Which issue(s) this PR fixes:

Relates to #105029

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

k8s-ci-robot · 2021-09-18T06:30:35Z

Welcome @shuheiktgw!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-09-18T06:30:36Z

Hi @shuheiktgw. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pacoxu

/ok-to-test

pacoxu · 2021-09-18T07:42:04Z

pkg/kubelet/apis/config/v1beta1/defaults_test.go

@@ -0,0 +1,216 @@
+/*
+Copyright 2015 The Kubernetes Authors.


pacoxu · 2021-09-18T07:48:20Z

pkg/kubelet/apis/config/v1beta1/defaults_test.go

+				MemoryThrottlingFactor:  utilpointer.Float64Ptr(DefaultMemoryThrottlingFactor),
+			},
+		},
+	}


To cover more code, I suggest we should have at least 3 cases:

empty is neccessage

all zero(0,"",0s,false) is a negative case

all settings(1,"xxx",60s,true) is positive case.

@pacoxu I added some more tests so would you review the PR again? 🙏

MadhavJivrajani · 2021-09-20T17:12:24Z

/priority backlog
/triage accepted

pacoxu

/lgtm
the code coverage for default.go is now 99.3%
👍

pacoxu · 2021-09-22T03:13:33Z

/label tide/merge-method-squash
/assign @lavalamp

ehashman

/label api-review
/cc @liggitt
/lgtm

ehashman · 2021-09-27T18:31:48Z

pkg/kubelet/apis/config/v1beta1/defaults_test.go

+			},
+		},
+		{
+			"NodeStatusUpdateFrequency is not zero",


What's the rationale behind this case?

Thank you for your review @ehashman! When NodeStatusReportFrequency is zero and NodeStatusUpdateFrequency is not zero, NodeStatusReportFrequency is equal to NodeStatusUpdateFrequency so I'd like to cover the case.

kubernetes/pkg/kubelet/apis/config/v1beta1/defaults.go

Lines 120 to 127 in f560a76

// For backward compatibility, NodeStatusReportFrequency's default value is

// set to NodeStatusUpdateFrequency if NodeStatusUpdateFrequency is set

// explicitly.

if obj.NodeStatusUpdateFrequency == zeroDuration {

obj.NodeStatusReportFrequency = metav1.Duration{Duration: 5 * time.Minute}

} else {

obj.NodeStatusReportFrequency = obj.NodeStatusUpdateFrequency

}

This test will end up needing to be updated for unrelated changes. Things get added rarely enough that this isn't a big deal, but this could have been a bit narrower to prevent knockon effects later. (non-blocking)

ehashman · 2021-09-27T18:32:16Z

pkg/kubelet/apis/config/v1beta1/defaults.go

@@ -178,9 +178,9 @@ func SetDefaults_KubeletConfiguration(obj *kubeletconfigv1beta1.KubeletConfigura
 	}
 	// default nil or negative value to -1 (implies node allocatable pid limit)
 	if obj.PodPidsLimit == nil || *obj.PodPidsLimit < int64(0) {
-		temp := int64(-1)
-		obj.PodPidsLimit = &temp
+		obj.PodPidsLimit = utilpointer.Int64(-1)


liggitt · 2021-09-30T16:59:21Z

thanks for the test and the review

/approve

k8s-ci-robot · 2021-09-30T16:59:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu, shuheiktgw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/kubelet/apis/config/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spiffxp · 2021-09-30T17:21:12Z

/test pull-kubernetes-node-e2e-containerd
ref: #105381

k8s-triage-robot · 2021-09-30T20:25:02Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2021-09-30T22:51:56Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

shuheiktgw added 2 commits September 18, 2021 15:21

Use utilpointer to get a pointer

f560a76

Add tests for kubelet default configs

7a1748e

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 18, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 18, 2021

k8s-ci-robot requested review from ehashman and yujuhong September 18, 2021 06:31

shuheiktgw mentioned this pull request Sep 18, 2021

Improve unit tests for Kubelet configuration APIs #105029

Closed

pacoxu reviewed Sep 18, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2021

pacoxu reviewed Sep 18, 2021

View reviewed changes

shuheiktgw added 3 commits September 18, 2021 17:58

Run gofmt

a3dc7c8

Add all negative and all positive test cases

d99610a

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2021

shuheiktgw mentioned this pull request Sep 19, 2021

Fix kubelet config comments #105130

Closed

ehashman added this to Triage in SIG Node PR Triage Sep 20, 2021

k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 20, 2021

MadhavJivrajani moved this from Triage to Needs Reviewer in SIG Node PR Triage Sep 20, 2021

pacoxu approved these changes Sep 22, 2021

View reviewed changes

k8s-ci-robot assigned pacoxu Sep 22, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021

k8s-ci-robot assigned lavalamp Sep 22, 2021

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 22, 2021

SergeyKanzhelev added this to Triage in SIG Node CI/Test Board Sep 22, 2021

SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Sep 22, 2021

pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Sep 24, 2021

ehashman moved this from PRs - Needs Reviewer to PRs - Needs Approver in SIG Node CI/Test Board Sep 27, 2021

ehashman reviewed Sep 27, 2021

View reviewed changes

k8s-ci-robot requested a review from liggitt September 27, 2021 18:32

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Sep 27, 2021

k8s-ci-robot assigned ehashman Sep 27, 2021

liggitt assigned liggitt and unassigned lavalamp Sep 30, 2021

liggitt added this to Assigned in API Reviews Sep 30, 2021

liggitt moved this from Assigned to In progress in API Reviews Sep 30, 2021

liggitt moved this from In progress to API review completed, 1.23 in API Reviews Sep 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021

k8s-ci-robot merged commit ef0eff1 into kubernetes:master Oct 1, 2021

SIG Node PR Triage automation moved this from Needs Approver to Done Oct 1, 2021

k8s-ci-robot added this to the v1.23 milestone Oct 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests kubelet default config #105116

Add tests kubelet default config #105116

shuheiktgw commented Sep 18, 2021

k8s-ci-robot commented Sep 18, 2021

k8s-ci-robot commented Sep 18, 2021

pacoxu left a comment

pacoxu Sep 18, 2021

pacoxu Sep 18, 2021 •

edited

shuheiktgw Sep 19, 2021

MadhavJivrajani commented Sep 20, 2021

pacoxu left a comment

pacoxu commented Sep 22, 2021

ehashman left a comment

ehashman Sep 27, 2021

shuheiktgw Sep 28, 2021

ehashman Sep 30, 2021

ehashman Sep 27, 2021

liggitt commented Sep 30, 2021

k8s-ci-robot commented Sep 30, 2021

spiffxp commented Sep 30, 2021 •

edited

k8s-triage-robot commented Sep 30, 2021

k8s-triage-robot commented Sep 30, 2021

	// For backward compatibility, NodeStatusReportFrequency's default value is
	// set to NodeStatusUpdateFrequency if NodeStatusUpdateFrequency is set
	// explicitly.
	if obj.NodeStatusUpdateFrequency == zeroDuration {
	obj.NodeStatusReportFrequency = metav1.Duration{Duration: 5 * time.Minute}
	} else {
	obj.NodeStatusReportFrequency = obj.NodeStatusUpdateFrequency
	}

Add tests kubelet default config #105116

Add tests kubelet default config #105116

Conversation

shuheiktgw commented Sep 18, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Sep 18, 2021

k8s-ci-robot commented Sep 18, 2021

pacoxu left a comment

Choose a reason for hiding this comment

pacoxu Sep 18, 2021

Choose a reason for hiding this comment

pacoxu Sep 18, 2021 • edited

Choose a reason for hiding this comment

shuheiktgw Sep 19, 2021

Choose a reason for hiding this comment

MadhavJivrajani commented Sep 20, 2021

pacoxu left a comment

Choose a reason for hiding this comment

pacoxu commented Sep 22, 2021

ehashman left a comment

Choose a reason for hiding this comment

ehashman Sep 27, 2021

Choose a reason for hiding this comment

shuheiktgw Sep 28, 2021

Choose a reason for hiding this comment

ehashman Sep 30, 2021

Choose a reason for hiding this comment

ehashman Sep 27, 2021

Choose a reason for hiding this comment

liggitt commented Sep 30, 2021

k8s-ci-robot commented Sep 30, 2021

spiffxp commented Sep 30, 2021 • edited

k8s-triage-robot commented Sep 30, 2021

k8s-triage-robot commented Sep 30, 2021

pacoxu Sep 18, 2021 •

edited

spiffxp commented Sep 30, 2021 •

edited