Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove format specifiers from structured logs #105144

Merged
merged 1 commit into from
Oct 4, 2021
Merged

remove format specifiers from structured logs #105144

merged 1 commit into from
Oct 4, 2021

Conversation

umangachapagain
Copy link
Contributor

@umangachapagain umangachapagain commented Sep 20, 2021 •
edited

proxy/winkernel/proxier.go was using format specifier with
structured logging pattern which is wrong. This commit removes
use of format specifiers to align with the pattern.

Signed-off-by: Umanga Chapagain chapagainumanga@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixes incorrectly migrated structured logs

Which issue(s) this PR fixes:

Fixes #105122

Special notes for your reviewer:

This issue surfaced while running structured logging checks #103293 (comment).

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

@umangachapagain: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @umangachapagain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2021
@umangachapagain
Copy link
Contributor Author

/wg structured-logging
/area logging
/priority important-soon
/kind cleanup

/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2021
@umangachapagain
Copy link
Contributor Author

/cc @serathius

@umangachapagain umangachapagain mentioned this pull request Sep 20, 2021
Merged
@shivanshuraj1333
Copy link
Contributor

LGTM,
/assign @serathius

@jyz0309 jyz0309 mentioned this pull request Sep 21, 2021
Merged
@Zheaoli
Copy link
Contributor

Zheaoli commented Sep 21, 2021

#105148 may need this

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2021
@serathius
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2021
shivanshuraj1333
shivanshuraj1333 suggested changes Sep 28, 2021
View reviewed changes
pkg/proxy/winkernel/proxier.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/proxier.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/proxier.go Outdated Show resolved Hide resolved
@shivanshuraj1333
Copy link
Contributor

@umangachapagain a full stop is not encouraged as a part of structured logging (ref migration guide), can you please make the necessary changes in the file? Please refer to review comments to get an idea, thanks!

shivanshuraj1333
shivanshuraj1333 suggested changes Sep 28, 2021
View reviewed changes
pkg/proxy/winkernel/proxier.go Outdated Show resolved Hide resolved
@umangachapagain umangachapagain mentioned this pull request Sep 29, 2021
Closed
7 tasks
@umangachapagain
fix incorrect structured log patterns
e262278 
proxy/winkernel/proxier.go was using format specifier with
structured logging pattern which is wrong. This commit removes
use of format specifiers to align with the pattern.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2021
@serathius
Copy link
Contributor

/lgtm
/assign @feiskyer

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2021
@umangachapagain
Copy link
Contributor Author

umangachapagain commented Oct 4, 2021 •
edited

/cc @sbangari @feiskyer

PTAL

@serathius
Copy link
Contributor

/cc @thockin

thockin
thockin reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2358c8a into kubernetes:master Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 4, 2021
@umangachapagain umangachapagain deleted the fix-logs branch October 5, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@jyz0309 jyz0309 jyz0309 left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@sbangari sbangari Awaiting requested review from sbangari

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

@serathius serathius Awaiting requested review from serathius

@shivanshuraj1333 shivanshuraj1333 Awaiting requested review from shivanshuraj1333

Assignees

@feiskyer feiskyer

@thockin thockin

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@umangachapagain @k8s-ci-robot @shivanshuraj1333 @Zheaoli @serathius @thockin @jyz0309 @yangjunmyfm192085 @feiskyer