Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mute unnecessary logs when failing to parse IPs #105218

Merged
merged 1 commit into from
Sep 24, 2021
Merged

mute unnecessary logs when failing to parse IPs #105218

merged 1 commit into from
Sep 24, 2021

Conversation

khenidak
Copy link
Contributor

@khenidak khenidak commented Sep 23, 2021 •
edited

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Fixes #105182

Which issue(s) this PR fixes:

Fixes #105182

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

/sig network
/assign @aojea

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

@khenidak: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@khenidak khenidak changed the title mute unnecessary logs mute unnecessary logs when failing to parse IPs Sep 23, 2021
aojea
aojea reviewed Sep 23, 2021
View reviewed changes
pkg/proxy/util/utils.go Outdated Show resolved Hide resolved
aojea
aojea reviewed Sep 23, 2021
View reviewed changes
pkg/proxy/util/utils.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2021
aojea
aojea reviewed Sep 23, 2021
View reviewed changes
pkg/proxy/util/utils.go Outdated Show resolved Hide resolved
@aojea
Copy link
Member

aojea commented Sep 23, 2021

/lgtm
/approve
Thanks for taking this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khenidak
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 005dfcd into kubernetes:master Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@khenidak khenidak deleted the fix-sig-net-105182 branch September 24, 2021 15:07
@hakman
Copy link
Member

hakman commented Nov 17, 2021

@aojea Any thoughts on cherry-picking this to the supported versions? Would create less panic for operators. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@danwinship danwinship Awaiting requested review from danwinship

@freehan freehan Awaiting requested review from freehan

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Constant 'Skipping invalid IP: ".' error entries in Kube-Proxy logs
4 participants
@khenidak @k8s-ci-robot @aojea @hakman