-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package paths referenced by import boss valid #105330
Conversation
/remove-sig api-machinery |
/retest |
i can't see what's wrong with verify deps job @liggitt
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
conflict in package declaration between a tools.go file already in
fixed in latest push |
b5b7bfb
to
f6b831a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
This PR seems to have broken the (probably incorrect) way I've been running tests.
Anyone coming here from
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
verify-import-boss.sh references package paths of the form
k8s.io/api/...
, but many of the staging repos roots are not valid go packages.This adds doc.go files to make them valid packages so that go package resolution works properly in gopath and go module mode.
Hoisted out of #99226. Prereq to #105299
Which issue(s) this PR fixes:
xref #82531
/area code-organization
/cc @dims