Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup FeatureGate skippers #105428

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Cleanup FeatureGate skippers #105428

merged 5 commits into from
Oct 20, 2021

Conversation

Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 3, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleanup skippers and use a common set of skipper functions instead

Which issue(s) this PR fixes:

Fixes #105351

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Git-Jiro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2021
mmiranda96
mmiranda96 suggested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@mmiranda96 mmiranda96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, test/e2e/common/storage/empty_dir.go#L300 requires using the new helper as well.

test/e2e/common/node/container_probe.go Outdated Show resolved Hide resolved
test/e2e/common/node/downwardapi.go Outdated Show resolved Hide resolved
test/e2e/common/storage/downwardapi.go Outdated Show resolved Hide resolved
test/e2e/storage/volume_limits.go Outdated Show resolved Hide resolved
test/e2e_node/podresources_test.go Outdated Show resolved Hide resolved
@mmiranda96
Copy link
Contributor

/ok-to-test
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 4, 2021
@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Oct 4, 2021
@ehashman ehashman added this to PRs - Needs Reviewer in SIG Node CI/Test Board Oct 4, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Oct 6, 2021
@mmiranda96
Copy link
Contributor

I've added another comment, on test/e2e/framework/skipper/skipper.go, but for some reason the resolved option hides it. Please take a look at this.

Also, I've reviewed with the community and it appears that the organization has decided to explicitly opt-out from Hacktoberfest (on almost all repositories, I believe). I'm not able to provide this PR with the hacktoberfest-accepted label, apologies for this.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 7, 2021

I completely understand the opting out of Hacktoberfest, because of the huge amount of Hacktoberfest related spam commits last year.

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 7, 2021

/retest

1 similar comment
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 7, 2021

/retest

@mmiranda96
Copy link
Contributor

These failures don't look like flakes. Let's try to debug them.

@mmiranda96
Copy link
Contributor

I'm noticing on the serial job logs the following error:

W1007 15:29:51.533] test/e2e_node/podresources_test.go:647:4: undefined: skipper.SkipIfFeatureGate
W1007 15:29:51.536] test/e2e_node/podresources_test.go:666:8: undefined: utilfeature

Please fix and then rerun tests.

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 8, 2021

/retest

1 similar comment
@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 8, 2021

/retest

@mmiranda96
Copy link
Contributor

It looks like everything is passing now! 🎉 Thanks for your contribution.
Please assign the suggested approvers.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@Git-Jiro Git-Jiro requested a review from pohly October 13, 2021 04:39
tallclair
tallclair reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Oct 18, 2021
@mmiranda96
Copy link
Contributor

Hi @pohly. Could you take another look?

pohly
pohly approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Git-Jiro, pohly, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit c9edee1 into kubernetes:master Oct 20, 2021
SIG Node CI/Test Board automation moved this from PRs Waiting on Author to Done Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 20, 2021
@Git-Jiro Git-Jiro deleted the cleanup_skipper branch October 20, 2021 10:08
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmiranda96 mmiranda96 mmiranda96 requested changes

@tallclair tallclair tallclair left review comments

@pohly pohly pohly approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@pohly pohly

@mmiranda96 mmiranda96

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Create skipper tool for FeatureGates
6 participants
@Git-Jiro @k8s-ci-robot @mmiranda96 @matthyx @pohly @tallclair