Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dead code in the ipvs proxy #105450

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Remove some dead code in the ipvs proxy #105450

merged 1 commit into from
Nov 12, 2021

Conversation

danwinship
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes some dead code in the IPVS proxy. Noticed in passing in #102493 (comment)

Does this PR introduce a user-facing change?

NONE

/sig network
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2021
@danwinship
Copy link
Contributor Author

/retest-required

aojea
aojea reviewed Oct 6, 2021
View reviewed changes
pkg/util/ipvs/ipvs_linux.go
@@ -45,14 +43,13 @@ type runner struct {
type Protocol uint16

// New returns a new Interface which will call ipvs APIs.
func New(exec utilexec.Interface) Interface {
func New() Interface {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing imports this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to cmd/kube-proxy/app/server_others.go I mean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the ipvs code is only used by kube-proxy and no other components

@aojea
Copy link
Member

aojea commented Oct 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@danwinship
Copy link
Contributor Author

/assign @andrewsykim

@khenidak
Copy link
Contributor

/lgtm
/approve

@aojea
Copy link
Member

aojea commented Oct 28, 2021

sudo @thockin 😄

@dcbw
Copy link
Member

dcbw commented Nov 9, 2021

/lgtm
too

@thockin thockin self-assigned this Nov 11, 2021
@thockin thockin added this to the v1.23 milestone Nov 11, 2021
thockin
thockin reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, khenidak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit c98b388 into kubernetes:master Nov 12, 2021
@danwinship danwinship deleted the ipvs-dead-code branch November 15, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@m1093782566 m1093782566 Awaiting requested review from m1093782566

Assignees

@thockin thockin

@aojea aojea

@khenidak khenidak

@dcbw dcbw

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danwinship @aojea @khenidak @dcbw @k8s-ci-robot @k8s-triage-robot @thockin @andrewsykim