sched: adjust events to register for VolumeBinding plugin #105546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/sig scheduling
What this PR does / why we need it:
VolumeBinding plugin now registered
NodeUpdate
event.kubernetes/pkg/scheduler/framework/plugins/volumebinding/volume_binding.go
Lines 105 to 108 in b0eac84
However,
NodeUpdate
is a superset of any changes of a node (labels, taints, conditions, etc.) This implies if a node's taints get changes, the pods failed by VolumeBinding plugin will also be moved back to activeQ (or backoffQ).This PR changes
NodeUpdate
to one of sub-categories:NodeLabelUpdate
and add a test to verify it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?