-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comment on ResourcePolicyRule #105555
Conversation
Track the long-ago addition of the ClusterScope field.
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/test pull-kubernetes-integration |
I am mystified about the generated swagger. pull-kubernetes-verify says
But when I do that, it makes no difference.
|
Rebase on latest master and |
4a39f68
to
c99e21d
Compare
@liggitt : thanks, the |
/triage accepted |
@fedebongio , @liggitt : what needs to happen for this to make progress? |
missed this was ready /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the comment on ResourcePolicyRule to account for the ClusterScope field, which was added long ago.
Which issue(s) this PR fixes:
Fixes #105393
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: