Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on ResourcePolicyRule #105555

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

MikeSpreitzer
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the comment on ResourcePolicyRule to account for the ClusterScope field, which was added long ago.

Which issue(s) this PR fixes:

Fixes #105393

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Track the long-ago addition of the ClusterScope field.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 7, 2021
@MikeSpreitzer
Copy link
Member Author

@kubernetes/sig-api-machinery-api-reviews
/cc @tkashem
/cc @lavalamp
/cc @deads2k
/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2021
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@MikeSpreitzer
Copy link
Member Author

/test pull-kubernetes-integration

@MikeSpreitzer
Copy link
Member Author

I am mystified about the generated swagger. pull-kubernetes-verify says

/home/prow/go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh

But when I do that, it makes no difference.

mspreitz@ubu20:~/go/src/k8s.io/kubernetes$ git status
On branch fix-105393
Your branch is up to date with 'origin/fix-105393'.

nothing to commit, working tree clean
mspreitz@ubu20:~/go/src/k8s.io/kubernetes$ hack/update-openapi-spec.sh
make: Entering directory '/home/mspreitz/go/src/k8s.io/kubernetes'
make[1]: Entering directory '/home/mspreitz/go/src/k8s.io/kubernetes'
Generating prerelease lifecycle code for 3 targets
Generating deepcopy code for 3 targets
Generating defaulter code for 3 targets
Generating conversion code for 3 targets
Generating openapi code for KUBE
make[1]: Leaving directory '/home/mspreitz/go/src/k8s.io/kubernetes'
+++ [1008 00:55:56] Building go targets for linux/amd64:
    cmd/kube-apiserver
> static build CGO_ENABLED=0: k8s.io/kubernetes/cmd/kube-apiserver
make: Leaving directory '/home/mspreitz/go/src/k8s.io/kubernetes'
etcd --advertise-client-urls http://127.0.0.1:2379 --data-dir /tmp/tmp.pSNEa25XtY --listen-client-urls http://127.0.0.1:2379 --log-level=debug > "/dev/null" 2>/dev/null
Waiting for etcd to come up.
+++ [1008 00:56:18] On try 2, etcd: : {"health":"true","reason":""}
{"header":{"cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"2","raft_term":"2"}}+++ [1008 00:56:18] Starting kube-apiserver
+++ [1008 00:56:23] On try 5, apiserver: : ok
+++ [1008 00:56:23] Updating 
    hack/../api/openapi-spec
+++ [1008 00:56:23] SUCCESS
+++ [1008 00:57:23] Clean up complete
mspreitz@ubu20:~/go/src/k8s.io/kubernetes$ 
mspreitz@ubu20:~/go/src/k8s.io/kubernetes$ git status
On branch fix-105393
Your branch is up to date with 'origin/fix-105393'.

nothing to commit, working tree clean

@liggitt
Copy link
Member

liggitt commented Oct 8, 2021

Rebase on latest master and make clean… it looks like you have alpha types/serving code still in your branch or binaries

@MikeSpreitzer
Copy link
Member Author

@liggitt : thanks, the make clean seems to have made the difference. I do not understand why that should be so.

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2021
@MikeSpreitzer
Copy link
Member Author

@fedebongio , @liggitt : what needs to happen for this to make progress?

@liggitt
Copy link
Member

liggitt commented Nov 15, 2021

missed this was ready

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7cf55fe into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
@MikeSpreitzer MikeSpreitzer deleted the fix-105393 branch November 16, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment on ResourcePolicyRule does not explain the ClusterScope field
5 participants