-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update extension point PostFilter comment #105584
update extension point PostFilter comment #105584
Conversation
@goofy-z: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @goofy-z. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
😂 maybe it's a wrong pr, can someone review this |
/assign |
/ok-to-test This was missed when when changed the semantics of PreFilter in the alpha phase. |
docs only change, deferring to scheduler reviewer /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goofy-z, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/sig scheduling
/kind documentation
What this PR does / why we need it:
According to [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/624-scheduling-framework#postfilter
Also I found the code:
kubernetes/pkg/scheduler/scheduler.go
Lines 455 to 469 in 80056f7
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?