Cleanup/remove service affinity plugin #105588

kerthcet · 2021-10-09T14:26:40Z

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

part of kubernetes/enhancements#2901

Which issue(s) this PR fixes:

Part of #92143

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2901

k8s-ci-robot · 2021-10-09T14:26:41Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2021-10-09T14:26:46Z

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2021-10-09T15:01:30Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

pkg/scheduler/apis/config/validation/validation_test.go

pkg/scheduler/apis/config/legacy_types.go

pkg/scheduler/apis/config/validation/validation_test.go

Huang-Wei

some nits. LGTM otherwise.

pkg/scheduler/apis/config/validation/validation_test.go

Huang-Wei · 2021-10-12T16:21:35Z

pkg/scheduler/apis/config/validation/validation_test.go

-		{
-			name: "different weights for ServiceAntiAffinity custom priority",
-			policy: config.Policy{
-				Priorities: []config.PriorityPolicy{
-					{Name: "customPriority1", Weight: 1, Argument: &config.PriorityArgument{ServiceAntiAffinity: &config.ServiceAntiAffinity{}}},
-					{Name: "customPriority2", Weight: 2, Argument: &config.PriorityArgument{ServiceAntiAffinity: &config.ServiceAntiAffinity{}}},
-				},
-			},
-			expected: errors.New("ServiceAntiAffinity  priority \"customPriority2\" has a different weight with \"customPriority1\""),
-		},


Ditto. Replace it instead of removing it.

different weights test covered here, and the logic is defined here, I thought there's no need to keep this test anymore.

pkg/scheduler/framework/plugins/legacy_registry.go

Huang-Wei · 2021-10-15T01:29:45Z

/lgtm
/approve

Huang-Wei · 2021-10-15T01:30:10Z

@kubernetes/api-reviewers for API review.

pkg/scheduler/apis/config/validation/validation.go

pkg/scheduler/apis/config/validation/validation_test.go

pkg/scheduler/apis/config/validation/validation.go

ahg-g · 2021-10-15T02:38:53Z

staging/src/k8s.io/kube-scheduler/config/v1/types.go

@@ -72,9 +72,6 @@ type PriorityPolicy struct {
 // PredicateArgument represents the arguments to configure predicate functions in scheduler policy configuration.
 // Only one of its members may be specified
 type PredicateArgument struct {
-	// The predicate that provides affinity for pods belonging to a service


@liggitt this may look strange, removing v1 types; but those types are not usable now that we completely removed the flag that allowed specifying the old policy configuration file and v1beta1 CC which used those types.

is it expected that the legacy types are removed piece mill? if we really can't load that file any more, can all the types in legacy_types be removed?

if we really can't load that file any more, can all the types in legacy_types be removed?

Yes, we will raise a PR right after this one to remove legacy_types.

yes, we want to remove the whole file, but there are a lot of things that needs cleaning up internally and this PR will help make the following one more manageable.

kerthcet · 2021-10-15T03:38:42Z

/test pull-kubernetes-unit

pkg/scheduler/apis/config/validation/validation.go

Signed-off-by: kerthcet <kerthcet@gmail.com>

ahg-g · 2021-10-18T14:47:58Z

/label api-review

ahg-g · 2021-10-18T14:51:24Z

please updated the description to say it is part of #92143

ahg-g · 2021-10-20T15:03:41Z

/lgtm
/approve

/label api-review

liggitt · 2021-10-20T15:12:09Z

/approve

liggitt · 2021-10-20T15:12:52Z

if this was already not usable because the legacy policy file could not be set, no release note is needed

k8s-ci-robot · 2021-10-20T15:12:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Huang-Wei, kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [liggitt]
~~pkg/scheduler/OWNERS~~ [Huang-Wei,ahg-g,liggitt]
~~staging/src/k8s.io/kube-scheduler/config/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kerthcet · 2021-10-20T15:17:55Z

if this was already not usable because the legacy policy file could not be set, no release note is needed

gotcha, done.

k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 9, 2021

k8s-ci-robot requested review from ahg-g and ncdc October 9, 2021 14:26

kerthcet marked this pull request as ready for review October 9, 2021 14:28

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2021

kerthcet mentioned this pull request Oct 9, 2021

Remove scheduler policy config and cc v1beta1 kubernetes/enhancements#2901

Closed

8 tasks

Huang-Wei reviewed Oct 10, 2021

View reviewed changes

pkg/scheduler/apis/config/validation/validation_test.go Outdated Show resolved Hide resolved

pkg/scheduler/apis/config/legacy_types.go Show resolved Hide resolved

kerthcet commented Oct 11, 2021

View reviewed changes

pkg/scheduler/apis/config/legacy_types.go Show resolved Hide resolved

pkg/scheduler/apis/config/validation/validation_test.go Outdated Show resolved Hide resolved

kerthcet force-pushed the cleanup/remove-servfice-affinity-plugin branch from 2a1d38c to b8700ec Compare October 12, 2021 11:45

Huang-Wei reviewed Oct 12, 2021

View reviewed changes

kerthcet force-pushed the cleanup/remove-servfice-affinity-plugin branch from b8700ec to c32f617 Compare October 14, 2021 05:22

k8s-ci-robot assigned Huang-Wei Oct 15, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2021

ahg-g reviewed Oct 15, 2021

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2021

ahg-g reviewed Oct 15, 2021

View reviewed changes

pkg/scheduler/apis/config/validation/validation.go Outdated Show resolved Hide resolved

remove scheduler ServiceAffinity plugin

fc9533e

Signed-off-by: kerthcet <kerthcet@gmail.com>

kerthcet force-pushed the cleanup/remove-servfice-affinity-plugin branch from 9ced79d to fc9533e Compare October 15, 2021 14:10

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Oct 18, 2021

kerthcet mentioned this pull request Oct 20, 2021

add introductions for scheduler component config api migrations kubernetes/website#30151

Merged

k8s-ci-robot assigned ahg-g Oct 20, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021

liggitt added this to API review completed, 1.23 in API Reviews Oct 20, 2021

k8s-ci-robot merged commit 9c97ae2 into kubernetes:master Oct 20, 2021

k8s-ci-robot added this to the v1.23 milestone Oct 20, 2021

kerthcet deleted the cleanup/remove-servfice-affinity-plugin branch October 21, 2021 00:23

This was referenced Sep 28, 2022

scheduler: remove unused plugin name ServiceAffinity #112766

Merged

scheduler: cleanup the unused event types about Service #112827

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup/remove service affinity plugin #105588

Cleanup/remove service affinity plugin #105588

kerthcet commented Oct 9, 2021 •

edited

k8s-ci-robot commented Oct 9, 2021

k8s-ci-robot commented Oct 9, 2021

k8s-triage-robot commented Oct 9, 2021

Huang-Wei left a comment

Huang-Wei Oct 12, 2021

kerthcet Oct 14, 2021

Huang-Wei commented Oct 15, 2021

Huang-Wei commented Oct 15, 2021

ahg-g Oct 15, 2021

liggitt Oct 19, 2021

Huang-Wei Oct 19, 2021

ahg-g Oct 19, 2021

kerthcet commented Oct 15, 2021

ahg-g commented Oct 18, 2021

ahg-g commented Oct 18, 2021

ahg-g commented Oct 20, 2021

liggitt commented Oct 20, 2021

liggitt commented Oct 20, 2021

k8s-ci-robot commented Oct 20, 2021

kerthcet commented Oct 20, 2021

Cleanup/remove service affinity plugin #105588

Cleanup/remove service affinity plugin #105588

Conversation

kerthcet commented Oct 9, 2021 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Oct 9, 2021

k8s-ci-robot commented Oct 9, 2021

k8s-triage-robot commented Oct 9, 2021

Huang-Wei left a comment

Choose a reason for hiding this comment

Huang-Wei Oct 12, 2021

Choose a reason for hiding this comment

kerthcet Oct 14, 2021

Choose a reason for hiding this comment

Huang-Wei commented Oct 15, 2021

Huang-Wei commented Oct 15, 2021

ahg-g Oct 15, 2021

Choose a reason for hiding this comment

liggitt Oct 19, 2021

Choose a reason for hiding this comment

Huang-Wei Oct 19, 2021

Choose a reason for hiding this comment

ahg-g Oct 19, 2021

Choose a reason for hiding this comment

kerthcet commented Oct 15, 2021

ahg-g commented Oct 18, 2021

ahg-g commented Oct 18, 2021

ahg-g commented Oct 20, 2021

liggitt commented Oct 20, 2021

liggitt commented Oct 20, 2021

k8s-ci-robot commented Oct 20, 2021

kerthcet commented Oct 20, 2021

kerthcet commented Oct 9, 2021 •

edited