adding `--ssh-key` and `--ssh-user` for kubetest2 #105637

Namanl2001 · 2021-10-12T17:15:19Z

Signed-off-by: Namanl2001 namanlakhwani@gmail.com

This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

--ssh-key and --ssh-user are not present for kubetest2, which is leading to this error: failed to run SSH command: out: Warning: Identity file /root/.ssh/google_compute_engine not accessible: No such file or directory :
ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/92316/pull-kubernetes-node-e2e-kubetest2/1446852497472753664#1:build-log.txt%3A114

Using these args in kubetest2 via kubernetes-sigs/kubetest2#169

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

k8s-ci-robot · 2021-10-12T17:15:26Z

@Namanl2001: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-10-12T17:15:26Z

Welcome @Namanl2001!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-10-12T17:15:27Z

Hi @Namanl2001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Namanl2001 · 2021-10-12T17:17:56Z

cc: @amwat @dims

amwat · 2021-10-12T18:06:16Z

/ok-to-test

amwat · 2021-10-12T18:11:37Z

/sig node
/sig testing
/kind feature
/release-note-none

amwat · 2021-10-12T18:16:43Z

hack/make-rules/test-e2e-node.sh

@@ -47,6 +47,8 @@ timeout_arg=""
 system_spec_name=${SYSTEM_SPEC_NAME:-}
 extra_envs=${EXTRA_ENVS:-}
 runtime_config=${RUNTIME_CONFIG:-}
+ssh_user=${SSH_USER:-}
+ssh_key=${SSH_KEY:-}


these would most likely be empty when not run with kubetest2 (i.e. directly make)
maybe add something like:
ssh_key=${SSH_KEY:-${GCE_SSH_PRIVATE_KEY_FILE:-${USER}/.ssh/google_compute_engine}}

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

amwat · 2021-10-12T22:56:20Z

/test pull-kubernetes-node-e2e-kubetest2

Namanl2001 · 2021-10-19T17:59:04Z

non kubetest2 jobs passes after adding quotes for SSH_USER let's try same with SSH_KEY

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

Namanl2001 · 2021-10-19T18:00:58Z

/test pull-kubernetes-node-e2e-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2

amwat · 2021-10-19T18:33:11Z

Oh I meant there might be an issue with how we are passing the args, not sure

https://github.com/kubernetes/test-infra/blob/183ddb6f2b5b38e8bf1dc43a9da4da5d911f832a/config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml#L136

https://github.com/kubernetes/test-infra/blob/183ddb6f2b5b38e8bf1dc43a9da4da5d911f832a/config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml#L268

The bash command is trying to run seems to be off https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/105637/pull-kubernetes-node-e2e-kubetest2/1450522436058484736#1:build-log.txt%3A293

[Serial]"

seems like we are somehow unquoting the skip flags and it's dropping everything before the pipe |
let's try using double quotes for the focus and skip regex.

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

Namanl2001 · 2021-10-19T19:36:58Z

reverted previous commit change: c6e0564
As it makes pull-kubernetes-e2e-gce-ubuntu-containerd to fail

amwat · 2021-10-19T22:12:50Z

/test pull-kubernetes-node-e2e-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2

amwat · 2021-10-19T23:22:12Z

looks like more quoting errors 😅

... ./ginkgo  -nodes=8  -focus=""\[NodeConformance\]""  -skip=""\[Flaky\]|\[Slow\]|\[Serial\]"" ...

the makefile seems to be adding it's own quotes

kubernetes/hack/make-rules/test-e2e-node.sh

Lines 57 to 63 in 6cbe185

    
           if [[ ${focus} != "" ]]; then 
        
             ginkgoflags="${ginkgoflags} -focus=\"${focus}\" " 
        
           fi 
        
           if [[ ${skip} != "" ]]; then 
        
             ginkgoflags="${ginkgoflags} -skip=\"${skip}\" " 
        
           fi

so we probably need to just pass it raw without any quotes

Namanl2001 · 2021-10-20T12:17:28Z

so we probably need to just pass it raw without any quotes

let's try this too 🤞

Namanl2001 · 2021-10-20T12:43:42Z

/test pull-kubernetes-node-e2e-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2

Namanl2001 · 2021-10-20T13:56:12Z

for the failure of /test pull-kubernetes-node-e2e-kubetest2 I think we should also remove quotes from --test-args

amwat · 2021-10-20T17:45:29Z

pull-kubernetes-node-e2e-containerd-kubetest2 successful run is awesome to see!

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/105637/pull-kubernetes-node-e2e-containerd-kubetest2/1450804977088860160

for the failure of /test pull-kubernetes-node-e2e-kubetest2 I think we should also remove quotes from --test-args

yeah, either that or quote the entire thing including --test-args similar to the containerd job
https://github.com/kubernetes/test-infra/blob/68b4c3bc47288a4314cf8dc46656be2d3ac6e784/config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml#L268

Namanl2001 · 2021-10-26T14:59:28Z

/test pull-kubernetes-node-e2e-kubetest2

Namanl2001 · 2021-10-26T15:36:13Z

🤩 Awesome to see green kubetest2 jobs. just testing the remaining ones

/test pull-kubernetes-node-e2e-containerd-features-kubetest2
/test pull-kubernetes-node-e2e-alpha-kubetest2
/test pull-kubernetes-node-kubelet-serial-kubetest2
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2

Namanl2001 · 2021-10-26T21:06:32Z

@amwat all tests should pass after the changes in this PR, right?

/retest

amwat · 2021-10-26T21:18:58Z

looking at the failures, seems like they are not related to ssh.
I would go ahead with this PR since that's what it's targetting

Stabilizing the other jobs might be involved and could need follow ups.

/lgtm
/approve

k8s-ci-robot · 2021-10-26T21:19:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, dims, Namanl2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [dims]
~~hack/OWNERS~~ [dims]
~~test/e2e_node/OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

amwat · 2021-10-26T21:59:02Z

/hold cancel

k8s-ci-robot · 2021-10-26T22:02:18Z

@Namanl2001: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-e2e-containerd-features-kubetest2	`d721796`	link	false	`/test pull-kubernetes-node-e2e-containerd-features-kubetest2`
pull-kubernetes-node-e2e-alpha-kubetest2	`d721796`	link	false	`/test pull-kubernetes-node-e2e-alpha-kubetest2`
pull-kubernetes-node-kubelet-serial-containerd-kubetest2	`d721796`	link	false	`/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`
pull-kubernetes-node-kubelet-serial-kubetest2	`d721796`	link	false	`/test pull-kubernetes-node-kubelet-serial-kubetest2`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adding key and user

ec7ad7e

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2021

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 12, 2021

k8s-ci-robot requested review from lavalamp and SataQiu October 12, 2021 17:16

Namanl2001 mentioned this pull request Oct 12, 2021

setting up and passing ssh-key kubernetes-sigs/kubetest2#169

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2021

amwat reviewed Oct 12, 2021

View reviewed changes

ssh key

be3c851

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

adding quote in SSH_KEY

c6e0564

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

Namanl2001 mentioned this pull request Oct 19, 2021

changing single quotes to double kubernetes/test-infra#24060

Merged

reverted previous commit change

d721796

Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>

Namanl2001 mentioned this pull request Oct 20, 2021

removing quotes in kubetest2 jobs config kubernetes/test-infra#24066

Merged

Namanl2001 mentioned this pull request Oct 20, 2021

removing unnecessary quotes from kubetest2 pre-submit jobs kubernetes/test-infra#24069

Merged

k8s-ci-robot assigned amwat Oct 26, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021

k8s-ci-robot merged commit 7c715db into kubernetes:master Oct 26, 2021

SIG Node CI/Test Board automation moved this from PRs Waiting on Author to Done Oct 26, 2021

k8s-ci-robot added this to the v1.23 milestone Oct 26, 2021

Namanl2001 deleted the ssh branch October 27, 2021 12:55

amwat mentioned this pull request Nov 12, 2021

kubetest2 CI migration kubernetes/enhancements#2464

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding `--ssh-key` and `--ssh-user` for kubetest2 #105637

adding `--ssh-key` and `--ssh-user` for kubetest2 #105637

Namanl2001 commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

Namanl2001 commented Oct 12, 2021

amwat commented Oct 12, 2021

amwat commented Oct 12, 2021

amwat Oct 12, 2021

amwat commented Oct 12, 2021

Namanl2001 commented Oct 19, 2021

Namanl2001 commented Oct 19, 2021

amwat commented Oct 19, 2021

Namanl2001 commented Oct 19, 2021

amwat commented Oct 19, 2021

amwat commented Oct 19, 2021

Namanl2001 commented Oct 20, 2021

Namanl2001 commented Oct 20, 2021

Namanl2001 commented Oct 20, 2021

amwat commented Oct 20, 2021

Namanl2001 commented Oct 26, 2021

Namanl2001 commented Oct 26, 2021

Namanl2001 commented Oct 26, 2021

amwat commented Oct 26, 2021

k8s-ci-robot commented Oct 26, 2021

amwat commented Oct 26, 2021

k8s-ci-robot commented Oct 26, 2021

adding --ssh-key and --ssh-user for kubetest2 #105637

adding --ssh-key and --ssh-user for kubetest2 #105637

Conversation

Namanl2001 commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

k8s-ci-robot commented Oct 12, 2021

Namanl2001 commented Oct 12, 2021

amwat commented Oct 12, 2021

amwat commented Oct 12, 2021

amwat Oct 12, 2021

Choose a reason for hiding this comment

amwat commented Oct 12, 2021

Namanl2001 commented Oct 19, 2021

Namanl2001 commented Oct 19, 2021

amwat commented Oct 19, 2021

Namanl2001 commented Oct 19, 2021

amwat commented Oct 19, 2021

amwat commented Oct 19, 2021

Namanl2001 commented Oct 20, 2021

Namanl2001 commented Oct 20, 2021

Namanl2001 commented Oct 20, 2021

amwat commented Oct 20, 2021

Namanl2001 commented Oct 26, 2021

Namanl2001 commented Oct 26, 2021

Namanl2001 commented Oct 26, 2021

amwat commented Oct 26, 2021

k8s-ci-robot commented Oct 26, 2021

amwat commented Oct 26, 2021

k8s-ci-robot commented Oct 26, 2021

adding `--ssh-key` and `--ssh-user` for kubetest2 #105637

adding `--ssh-key` and `--ssh-user` for kubetest2 #105637