Refactor to use structure to pass parameters for GracefulNodeShutdown #105652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
wzshiming
force-pushed
the
feat/structure-shutdown-config
branch
3 times, most recently
from
8e55f8e
to
bd163bb
Compare
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
bobbypage
reviewed
Oct 14, 2021
| clock: clock.RealClock{}, | ||
| probeManager: probeManager, | ||
| func NewManager(conf *Config) (Manager, lifecycle.PodAdmitHandler) { | ||
| if conf.ShutdownGracePeriodRequested == 0 && conf.ShutdownGracePeriodCriticalPods == 0 { |
There was a problem hiding this comment.
Can we add unit test that this config (ShutdownGracePeriodRequested = 0 and ShutdownGracePeriodCriticalPods = 0) will return stub manager that performs no-ops? We previously had TestFeatureEnabled unit test for this.
wzshiming
force-pushed
the
feat/structure-shutdown-config
branch
from
a5a444e
to
e47c78a
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #102915
Special notes for your reviewer:
#102915, I think this naming is still a bit controversial, I sent a new PR to do the refactoring part to use structure to pass parameters to reduce the workload of conflict resolution.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @mrunalp @bobbypage