Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated ipvs/proxier.go(remaining) to structured logging #105770

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Migrated ipvs/proxier.go(remaining) to structured logging #105770

merged 3 commits into from
Oct 21, 2021

Conversation

shivanshuraj1333
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixed incorrectly migrated logs
Migrated some missing logs to structured logging

Which issue(s) this PR fixes:

Ref: #104872

Special notes for your reviewer:

In this PR, I've cleaned up some improperly migrated logs, going forward we need to figure out a way to make every migration follow the guide, #105718 (comment)
Also, this PR contains the remaining partial migration of ipvs/proxier.go after #105769

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

@shivanshu1333: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 19, 2021
@shivanshuraj1333
Copy link
Contributor Author

/assign @serathius

@k8s-ci-robot k8s-ci-robot added area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2021
@shivanshuraj1333
Copy link
Contributor Author

/wg structured-logging
/area logging
/priority important-soon
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 19, 2021
@shivanshuraj1333
Copy link
Contributor Author

/remove do-not-merge/contains-merge-commits

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 20, 2021
@shivanshuraj1333
Copy link
Contributor Author

using label to squash
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 20, 2021
@shivanshuraj1333
Copy link
Contributor Author

ping @serathius for re-review

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@shivanshuraj1333
Copy link
Contributor Author

/retest

@shivanshuraj1333
Copy link
Contributor Author

ping @MrHohn for approval

@shivanshuraj1333
Copy link
Contributor Author

/retest

@shivanshuraj1333
Copy link
Contributor Author

/retest

@shivanshuraj1333
Copy link
Contributor Author

/retest-required

@shivanshuraj1333
Copy link
Contributor Author

/honk

@k8s-ci-robot
Copy link
Contributor

@shivanshu1333:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shivanshuraj1333
Copy link
Contributor Author

/test pull-kubernetes-e2e-gci-gce-ipvs

aojea
aojea reviewed Oct 21, 2021
View reviewed changes
pkg/proxy/ipvs/proxier.go
@@ -1982,15 +1982,15 @@ func (proxier *Proxier) syncService(svcName string, vs *utilipvs.VirtualServer,
if appliedVirtualServer == nil || !appliedVirtualServer.Equal(vs) {
if appliedVirtualServer == nil {
// IPVS service is not found, create a new service
klog.V(3).InfoS("Adding new service", "svcName", svcName, "address", fmt.Sprintf("%s:%d/%s", vs.Address, vs.Port, vs.Protocol))
klog.V(3).InfoS("Adding new service", "serviceName", svcName, "virtualServer", vs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, it has a stringer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aojea
Copy link
Member

aojea commented Oct 21, 2021

/approve
Test failures seems unrelated

Kubernetes e2e suite: [sig-node] PreStop graceful pod terminated should wait until preStop hook completes the process expand_more

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, shivanshu1333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021
@shivanshuraj1333 shivanshuraj1333 mentioned this pull request Oct 21, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit 86aed49 into kubernetes:master Oct 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 21, 2021
@shivanshuraj1333 shivanshuraj1333 mentioned this pull request Oct 28, 2021
Closed
@reylejano reylejano mentioned this pull request Nov 18, 2021
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@aojea aojea aojea left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shivanshuraj1333 @k8s-ci-robot @serathius @aojea