Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuberuntime: augment linux container config unit test #105772

Merged
merged 1 commit into from
Oct 20, 2021
Merged

kuberuntime: augment linux container config unit test #105772

merged 1 commit into from
Oct 20, 2021

Conversation

egernst
Copy link
Contributor

@egernst egernst commented Oct 19, 2021 •
edited

Signed-off-by: Eric Ernst eric_ernst@apple.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Let's improve the unit tests for kuberuntime, ever so slightly!

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

This is related to #104886

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

n/a

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: egernst
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@egernst egernst mentioned this pull request Oct 19, 2021
Merged
@egernst
Copy link
Contributor Author

egernst commented Oct 19, 2021

/test pull-kubernetes-node-e2e-containerd

@egernst
Copy link
Contributor Author

egernst commented Oct 19, 2021

/test pull-kubernetes-integration

@egernst
Copy link
Contributor Author

egernst commented Oct 19, 2021

/test pull-kubernetes-node-e2e-containerd

@ehashman ehashman added this to Triage in SIG Node PR Triage Oct 19, 2021
@wgahnagl
Copy link
Contributor

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2021
@wgahnagl wgahnagl moved this from Triage to Waiting on Author in SIG Node PR Triage Oct 20, 2021
@egernst egernst force-pushed the augment-unit-test-kuberuntime branch from a34830e to e1cf123 Compare October 20, 2021 18:24
@egernst
Copy link
Contributor Author

egernst commented Oct 20, 2021

Thanks for the feedback Skyler.

I pushed an update to address your feedback. PTAL

@egernst egernst requested a review from wgahnagl October 20, 2021 18:25
@wgahnagl
Copy link
Contributor

Thanks for the feedback Skyler.

I pushed an update to address your feedback. PTAL

looks great ! 👍

@egernst
kuberuntime: augment linux container config unit test
a73502a 
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
@egernst egernst force-pushed the augment-unit-test-kuberuntime branch from e1cf123 to a73502a Compare October 20, 2021 18:29
@k8s-ci-robot
Copy link
Contributor

@egernst: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-100-performance a73502a link true /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit a73502a into kubernetes:master Oct 20, 2021
SIG Node PR Triage automation moved this from Waiting on Author to Done Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 20, 2021
@egernst egernst deleted the augment-unit-test-kuberuntime branch October 21, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@vishh vishh Awaiting requested review from vishh

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@egernst @k8s-ci-robot @wgahnagl