Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick of #101708: Fix log spam for du failure on pod etc-hosts metrics #105887

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Cherry-pick of #101708: Fix log spam for du failure on pod etc-hosts metrics #105887

merged 1 commit into from
Nov 8, 2021

Conversation

AnishShah
Copy link
Contributor

@AnishShah AnishShah commented Oct 25, 2021 •
edited

What type of PR is this?

Cherry-pick of #101708

/kind bug

What this PR does / why we need it:

#97042 added changes in 1.21 version that caused log spam in kubelet logs with the following message -

"Unable to fetch pod etc hosts stats" err="failed to get stats failed command 'du' ($ nice -n 19 du -x -s -B 1) on path /var/lib/kubelet/pods/d451e557-9ff8-4cc6-91d3-6cfc21e7ea4f/etc-hosts with error exit status 1" pod="openshift-dns/node-resolver-tckq7"

#101708 was sent to fix this but it was merged in 1.22 version only. This PR cherry-picks the commit to 1.21 version.

So we were wondering if this can be cherry-picked onto 1.21

Which issue(s) this PR fixes:

Cherry-pick of #101708

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AnishShah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2021
@AnishShah
Copy link
Contributor Author

Tagging original authors and reviewers of #101708 - @joelsmith, @rphillips, @saschagrunert

@AnishShah AnishShah changed the title Fix log spam for du failure on pod etc-hosts metrics Cherry-pick of #101708: Fix log spam for du failure on pod etc-hosts metrics Oct 25, 2021
@AnishShah
Copy link
Contributor Author

/assign @dashpole

@dashpole
Copy link
Contributor

/ok-to-test
/approve
(you still need cherry-pick approval)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@AnishShah
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@AnishShah
Copy link
Contributor Author

AnishShah commented Oct 25, 2021 •
edited

/assign @saschagrunert

@saschagrunert, Need a cherry-pick approval from you.

@saschagrunert
Copy link
Member

Hey @AnishShah, the cherry-pick deadline for 1.21.6 was Oct 22, so this is going to be part of the following patch iteration.

@joelsmith
Copy link
Contributor

/lgtm
Thanks for backporting!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Nov 1, 2021
@wgahnagl
Copy link
Contributor

wgahnagl commented Nov 3, 2021

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 3, 2021
@wgahnagl
Copy link
Contributor

wgahnagl commented Nov 3, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2021
@wgahnagl wgahnagl moved this from Triage to Needs Approver in SIG Node PR Triage Nov 3, 2021
saschagrunert
saschagrunert approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnishShah, dashpole, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bdf26ad into kubernetes:release-1.21 Nov 8, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 8, 2021
@AnishShah AnishShah deleted the cp-1.21 branch November 8, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@joelsmith joelsmith

@saschagrunert saschagrunert

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AnishShah @k8s-ci-robot @dashpole @saschagrunert @joelsmith @wgahnagl