Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return value is taken from if statement instead of the function call #105920

Merged
merged 1 commit into from
Nov 1, 2021
Merged

return value is taken from if statement instead of the function call #105920

merged 1 commit into from
Nov 1, 2021

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind bug
/sig node
/sig cloud-provider

What this PR does / why we need it:

Return value that was intended to be the function exit code, is actually an if statement exit code. Which make the logic misbehave.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Oct 26, 2021
@249043822
Copy link
Member

/triage accepted
seems make sense, lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 27, 2021
@249043822 249043822 added this to Needs Reviewer in SIG Node PR Triage Oct 27, 2021
@matthyx
Copy link
Contributor

matthyx commented Oct 27, 2021

/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2021
@matthyx matthyx moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Oct 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
@SergeyKanzhelev
Copy link
Member Author

/assign @cheftako

for approval

@cheftako
Copy link
Member

cheftako commented Nov 1, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 37efc5f into kubernetes:master Nov 1, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@cheftako cheftako

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeyKanzhelev @249043822 @matthyx @cheftako @k8s-ci-robot