Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed graduation of evictions_number metric to stable #105864

Closed
vantuvt opened this issue Oct 24, 2021 · 9 comments · Fixed by #106366
Closed

Proposed graduation of evictions_number metric to stable #105864

vantuvt opened this issue Oct 24, 2021 · 9 comments · Fixed by #106366
Assignees
@dgrisonnet @cyclinder
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@vantuvt
Copy link
Contributor

vantuvt commented Oct 24, 2021

What would you like to be added?

I would like to propose the graduation of the evictions_number metric from alpha to stable.

Why is this needed?

The evictions_number metric has been stable for 2 years now.
@vantuvt vantuvt added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2021
@vantuvt
Copy link
Contributor Author

vantuvt commented Oct 24, 2021

/sig api-machinery
/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2021
@cyclinder
Copy link
Contributor

https://github.com/kubernetes/kubernetes/blame/0d50c969c587c8a6c16e0962118305ac652c5a6b/pkg/controller/nodelifecycle/metrics.go#L35-67
I am willing to do this.change all StabilityLevels from alpha to stable? Is that right?

@cyclinder
Copy link
Contributor

/assign

@vantuvt
Copy link
Contributor Author

vantuvt commented Oct 25, 2021

@cyclinder - The request is to have the stability level for the evictions_number metric graduate to stable. If there are other metrics you want to do at the same time that's a bonus, but not part of the request in this issue.

@caesarxuchao
Copy link
Member

/sig node
/remove-sig api-machinery
/cc @logicalhan

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 26, 2021
@dgrisonnet
Copy link
Member

To be promoted to stable, the metrics would need to be renamed from evictions_number to evictions_total in order to follow Prometheus best practices as well as sig-instrumentation naming guidelines. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/instrumentation.md#naming.

This was referenced Oct 27, 2021
Closed
Closed
@erain
Copy link
Contributor

erain commented Oct 29, 2021

/cc

@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2021

/assign @dgrisonnet

@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2021
@cyclinder cyclinder mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrisonnet dgrisonnet

@cyclinder cyclinder

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
7 participants
@erain @caesarxuchao @dashpole @k8s-ci-robot @dgrisonnet @vantuvt @cyclinder