-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Assert max unavailable for PDB test cases #105960
test: Assert max unavailable for PDB test cases #105960
Conversation
Welcome @ueokande! |
Hi @ueokande. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ueokande Could you squash these commits? |
0df5611
to
5c76507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
/priority backlog
/triage accepted
Nice catch, thx! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, ueokande The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change asserts max unavailable for PDB test cases. Test cases "test-valid-max-unavailable-pods-***" has been asserted MinAvailable rather than MaxUnavailable. I believe they had incorrect parameter.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: