Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COS GPU driver installation #105989

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fix COS GPU driver installation #105989

merged 1 commit into from
Oct 30, 2021

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Oct 29, 2021 •
edited

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #104175

Special notes for your reviewer:

Tested by running kubetest manually

Invocation - https://gist.github.com/d97bbe0717bf3c8234fec10beda4ff0a
Build log - https://gist.github.com/88b3096ba1338e659d68e83857e13ab5

• [SLOW TEST:297.012 seconds]
[sig-node] NVIDIA GPU Device Plugin [Feature:GPUDevicePlugin][NodeFeature:GPUDevicePlugin][Serial] [Disruptive]
_output/local/go/src/k8s.io/kubernetes/test/e2e_node/framework.go:23
  DevicePlugin
  _output/local/go/src/k8s.io/kubernetes/test/e2e_node/gpu_device_plugin_test.go:66
    keeps GPU assignment to pods across pod and kubelet restarts.
    _output/local/go/src/k8s.io/kubernetes/test/e2e_node/gpu_device_plugin_test.go:157
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSI1029 01:07:31.171986    1188 e2e_node_suite_test.go:237] Stopping node services...
I1029 01:07:31.172032    1188 server.go:257] Kill server "services"
I1029 01:07:31.172187    1188 server.go:294] Killing process 2280 (services) with -TERM
E1029 01:07:31.228088    1188 services.go:95] Failed to stop services: error stopping "services": waitid: no child processes
I1029 01:07:31.228122    1188 server.go:257] Kill server "kubelet"
I1029 01:07:31.239057    1188 services.go:156] Fetching log files...
I1029 01:07:31.239138    1188 services.go:165] Get log file "kern.log" with journalctl command [-k].
I1029 01:07:31.248936    1188 services.go:165] Get log file "cloud-init.log" with journalctl command [-u cloud*].
I1029 01:07:31.606801    1188 services.go:165] Get log file "docker.log" with journalctl command [-u docker].
I1029 01:07:31.612496    1188 services.go:165] Get log file "containerd.log" with journalctl command [-u containerd].
I1029 01:07:31.618332    1188 services.go:165] Get log file "containerd-installation.log" with journalctl command [-u containerd-installation].
I1029 01:07:31.621690    1188 e2e_node_suite_test.go:242] Tests Finished

JUnit report was created: /tmp/node-e2e-20211028T180026/results/junit_cos-stable2_01.xml

Ran 1 of 359 Specs in 413.040 seconds
SUCCESS! -- 1 Passed | 0 Failed | 1 Pending | 357 Skipped
PASS

Ginkgo ran 1 suite in 6m53.257503373s
Test Suite Passed

Success Finished Test Suite on Host n1-standard-2-cos-93-16623-39-6-1f4a05b2

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@bobbypage
Fix COS GPU driver installation
e1a951a 
* Rely on the built in GPU driver installer in COS as recommended in
  public docs - https://cloud.google.com/container-optimized-os/docs/how-to/run-gpus
* Run `nvidia-smi` after installation to verify installation
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2021
@bobbypage
Copy link
Member Author

/cc @SergeyKanzhelev @endocrimes @ehashman

@bobbypage bobbypage mentioned this pull request Oct 29, 2021
Closed
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 29, 2021
@bobbypage
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial

@k8s-ci-robot
Copy link
Contributor

@bobbypage: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial e1a951a link false /test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 29, 2021
View reviewed changes
test/e2e_node/jenkins/gci-init-gpu.yaml
- mount --bind /var/lib/nvidia /var/lib/nvidia
- mount -o remount,exec /var/lib/nvidia /var/lib/nvidia
# Run nvidia-smi to verify installation
- /var/lib/nvidia/bin/nvidia-smi
# Remove build containers. They're very large.
- docker rm -f $(docker ps -aq)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still needed? does cos-extensions uses docker?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let'e merge this to see if tests pass, need to follow up on this line removal

@SergeyKanzhelev
Copy link
Member

cool. Just a small question, lgtm otherwise

@SergeyKanzhelev
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2021
endocrimes
endocrimes approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks! - I was unfamiliar with cos when fixing this the last time

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, endocrimes, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc6890f into kubernetes:master Oct 30, 2021
SIG Node CI/Test Board automation moved this from Triage to Done Oct 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@ehashman ehashman Awaiting requested review from ehashman

@mrunalp mrunalp Awaiting requested review from mrunalp

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
4 participants
@bobbypage @k8s-ci-robot @SergeyKanzhelev @endocrimes