-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: extract multiple ignore errors validate logic to isExpectedError #106041
kubelet: extract multiple ignore errors validate logic to isExpectedError #106041
Conversation
/release-note-none |
maybe /sig-storage |
abd69da
to
a945419
Compare
/ok-to-test |
/triage accepted |
/cc @jingxu97 PTAL |
Signed-off-by: haoyun <yun.hao@daocloud.io>
a945419
to
b5409ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jsafrane for approve |
@jonyhy96: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: endocrimes, jingxu97, jonyhy96, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Same error validate logic and comment has appeared multiple times
Better extract them into a public function call
Special notes for your reviewer:
None