Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #105839: fix: remove VMSS and VMSS instances from SLB backend pool #106075

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Automated cherry pick of #105839: fix: remove VMSS and VMSS instances from SLB backend pool #106075

merged 1 commit into from
Jan 12, 2022

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Nov 2, 2021

Cherry pick of #105839 on release-1.21.

#105839: fix: remove VMSS and VMSS instances from SLB backend pool

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

@nilo19: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2021
@nilo19
Copy link
Member Author

nilo19 commented Nov 2, 2021

/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted
/kind bug
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 2, 2021
@nilo19 nilo19 force-pushed the automated-cherry-pick-of-#105839-upstream-release-1.21 branch 2 times, most recently from e5d4633 to a910a44 Compare November 2, 2021 06:19
@nilo19 nilo19 force-pushed the automated-cherry-pick-of-#105839-upstream-release-1.21 branch from a910a44 to af7e497 Compare November 2, 2021 07:19
feiskyer
feiskyer approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@puerco puerco mentioned this pull request Nov 12, 2021
Merged
@nilo19
Copy link
Member Author

nilo19 commented Nov 14, 2021

@cheftako can you help to approve?

@nilo19
Copy link
Member Author

nilo19 commented Dec 7, 2021

kindly ping @cheftako to approve

@nilo19
Copy link
Member Author

nilo19 commented Dec 14, 2021

@cheftako can we merge this? Many users are facing this issue.

@jackfrancis
Copy link
Contributor

/assign @andrewsykim @dims

If either of you are around, are you aware of why this (and the 1.20 and 1.22) cherry-picks of this PR aren't yet merged? Are there concerns?

Thanks!

@nilo19
Copy link
Member Author

nilo19 commented Dec 17, 2021

I have a lot of bug fixes/cherry-picks that are pending approval for a very long time.

andrewsykim
andrewsykim reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@bridgetkromhout
Copy link
Member

Hi, @kubernetes/release-managers - please review this cherry-pick! Thanks.

cpanato
cpanato approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, cpanato, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0588352 into kubernetes:release-1.21 Jan 12, 2022
@nilo19 nilo19 deleted the automated-cherry-pick-of-#105839-upstream-release-1.21 branch January 13, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@feiskyer feiskyer feiskyer approved these changes

@cpanato cpanato cpanato approved these changes

@karataliu karataliu Awaiting requested review from karataliu

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@dims dims

@feiskyer feiskyer

@cpanato cpanato

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nilo19 @k8s-ci-robot @jackfrancis @bridgetkromhout @feiskyer @cpanato @andrewsykim @dims