Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #105997: Fixing how EndpointSlice Mirroring handles Service selector #106135

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Automated cherry pick of #105997: Fixing how EndpointSlice Mirroring handles Service selector #106135

merged 1 commit into from
Nov 5, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Nov 3, 2021 •
edited

Cherry pick of #105997 on release-1.21.

#105997: Fixing how EndpointSlice Mirroring handles Service selector

For details on the cherry pick process, see the cherry pick requests page.

EndpointSlice Mirroring controller now cleans up managed EndpointSlices when a Service selector is added

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2021
@k8s-ci-robot
Copy link
Contributor

@robscott: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2021
@robscott robscott force-pushed the automated-cherry-pick-of-#105997-upstream-release-1.21 branch from e65b60e to a2bfd06 Compare November 3, 2021 23:49
@robscott
Copy link
Member Author

robscott commented Nov 3, 2021

/kind bug
/sig network
/priority important-soon
/cc @aojea
/assign @thockin

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 3, 2021
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 3, 2021
@robscott robscott force-pushed the automated-cherry-pick-of-#105997-upstream-release-1.21 branch 2 times, most recently from efbb5f8 to 4e9d4db Compare November 3, 2021 23:53
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 3, 2021
@robscott robscott force-pushed the automated-cherry-pick-of-#105997-upstream-release-1.21 branch from 4e9d4db to f6c1e74 Compare November 4, 2021 00:06
@robscott robscott force-pushed the automated-cherry-pick-of-#105997-upstream-release-1.21 branch from f6c1e74 to 2fda32e Compare November 4, 2021 00:08
@aojea
Copy link
Member

aojea commented Nov 4, 2021

/lgtm
/approve
ping @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
@thockin
Copy link
Member

thockin commented Nov 4, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
saschagrunert
saschagrunert approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, robscott, saschagrunert, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit f17886e into kubernetes:release-1.21 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@thockin thockin Awaiting requested review from thockin

@aojea aojea Awaiting requested review from aojea

Assignees

@saschagrunert saschagrunert

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@robscott @k8s-ci-robot @aojea @thockin @k8s-triage-robot @saschagrunert