oidc authenticator: allow http.Client to be overridden #106141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
priority/backlog
k8s-ci-robot
added
area/apiserver
sig/api-machinery
liggitt
reviewed
Nov 5, 2021
| @@ -81,9 +81,12 @@ type Options struct { | |||
| // See: https://openid.net/specs/openid-connect-core-1_0.html#IDToken | |||
| ClientID string | |||
|
|
|||
| // PEM encoded root certificate contents of the provider. | |||
| // PEM encoded root certificate contents of the provider. Ignored when Client is not nil. | |||
There was a problem hiding this comment.
would it be better to make this and Client mutually exclusive?
There was a problem hiding this comment.
Yeah I think so. Updated and added unit test.
liggitt
reviewed
Nov 5, 2021
| ClientID: "my-client", | ||
| UsernameClaim: "username", | ||
| GroupsClaim: "groups", | ||
| Client: http.DefaultClient, // cause distributed claims fetching to fail with an unknown CA error |
There was a problem hiding this comment.
any way to verify the error or verify this client gets called?
There was a problem hiding this comment.
Updated the test logic so that I could assert the returned error.
enj
force-pushed
the
enj/i/oidc_client
branch
from
36ebc3a
to
2cb0b5b
Compare
k8s-ci-robot
added
size/L
This change allows the http.Client used by the OIDC authenticator to be overridden. This is useful when this code is being used as a library outside of core Kubernetes. For example, a downstream consumer may want to override the http.Client's internals such as its TLS configuration. Signed-off-by: Monis Khan <mok@vmware.com>
enj
force-pushed
the
enj/i/oidc_client
branch
from
2cb0b5b
to
11974cd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
margocrawf
added a commit
to vmware-tanzu/pinniped
that referenced
this pull request
Apr 18, 2022
Kube 1.23 introduced a new field on the OIDC Authenticator which allows us to pass in a client with our own TLS config. See kubernetes/kubernetes#106141. Signed-off-by: Margo Crawford <margaretc@vmware.com>
margocrawf
added a commit
to vmware-tanzu/pinniped
that referenced
this pull request
Apr 19, 2022
Kube 1.23 introduced a new field on the OIDC Authenticator which allows us to pass in a client with our own TLS config. See kubernetes/kubernetes#106141. Signed-off-by: Margo Crawford <margaretc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the http.Client used by the OIDC authenticator to
be overridden. This is useful when this code is being used as a
library outside of core Kubernetes. For example, a downstream
consumer may want to override the http.Client's internals such as
its TLS configuration.
Signed-off-by: Monis Khan mok@vmware.com
/kind cleanup
/milestone v1.23
/triage accepted
/priority backlog
/assign @liggitt
xref: #99765