Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest kubedns and nodelocaldns images. #106189

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Update to latest kubedns and nodelocaldns images. #106189

merged 1 commit into from
Nov 5, 2021

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Nov 5, 2021

What type of PR is this?

What this PR does / why we need it:

This PR updates the kubedns and nodelocaldns yamls to use the latest patched images.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

@prameshj: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2021
@prameshj prameshj mentioned this pull request Nov 5, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
MrHohn
MrHohn approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@aojea
Copy link
Member

aojea commented Nov 5, 2021

/kind cleanup
/approve

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 88c000e into kubernetes:master Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 5, 2021
Nsikak1-2
Nsikak1-2 reviewed Jan 16, 2024
View reviewed changes
Copy link

@Nsikak1-2 Nsikak1-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pullout request

Nsikak1-2
Nsikak1-2 reviewed Jan 16, 2024
View reviewed changes
Copy link

@Nsikak1-2 Nsikak1-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pullout request

Nsikak1-2
Nsikak1-2 reviewed Jan 16, 2024
View reviewed changes
Copy link

@Nsikak1-2 Nsikak1-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment change

cluster/addons/dns/kube-dns/kube-dns.yaml.base
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster/addons/dns/kube-dns/kube-dns.yaml.base

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request change

Nsikak1-2
Nsikak1-2 reviewed Jan 16, 2024
View reviewed changes
cluster/addons/dns/kube-dns/kube-dns.yaml.base
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster/addons/dns/kube-dns/kube-dns.yaml.base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nsikak1-2 Nsikak1-2 Nsikak1-2 left review comments

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prameshj @k8s-ci-robot @aojea @MrHohn @Nsikak1-2