-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of the administrator_keys_file file with many users #106196
Fix creation of the administrator_keys_file file with many users #106196
Conversation
/sig windows |
/triage accepted |
I gave this a cursory review and I sort-of understand what it does. This is delicate legacy code that's specifically testonly, hopefully in 2022 Windows VMs on GCE will gain ssh capability by default and we'll be able to remove this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauriciopoppe, pjh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a couple of things:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/cc @pjh