e2e_node: fixes after dynamic configuration removal #106210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig node |
k8s-ci-robot
added
sig/node
|
/test |
|
@cynepco3hahue: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-kubelet-serial-cpu-manager |
|
@SergeyKanzhelev Hi, can you please review, it is the follow-up after dropping the dynamic kubelet configuration. |
cynepco3hahue
force-pushed
the
e2e_node_fixes_after_dynamic_confiuration
branch
from
b7b51ae
to
bc5b20b
Compare
| @@ -85,7 +85,7 @@ func registerNodeFlags(flags *flag.FlagSet) { | |||
| // It is hard and unnecessary to deal with the complexity inside the test suite. | |||
| flags.BoolVar(&framework.TestContext.NodeConformance, "conformance", false, "If true, the test suite will not start kubelet, and fetch system log (kernel, docker, kubelet log etc.) to the report directory.") | |||
| flags.BoolVar(&framework.TestContext.PrepullImages, "prepull-images", true, "If true, prepull images so image pull failures do not cause test failures.") | |||
| flags.BoolVar(&framework.TestContext.RestartKubelet, "restart-kubelet", true, "If true, restart Kubelet unit when the process is killed.") | |||
| flags.BoolVar(&framework.TestContext.RestartKubelet, "restart-kubelet", false, "If true, restart Kubelet unit when the process is killed.") | |||
There was a problem hiding this comment.
Now that we do not have DynamicKubelet configuration, we do not need to run a restart loop.
How did it work before:
- Test updated kubelet via DynamicKubeletConfiguration
- DynamicKubeletConfiguration controller applied updated configuration and stopped the kubelet.
- The restart loop monitors the kubelet health link and once it does not respond restart the kubelet.
How does it work now:
- The test stops the kubelet.
- The test update kubelet static configuration.
- The test restarts kubelet.
So now it totally tests responsibility to make sure the kubelet runs after the test. It makes restarts more predictable because it is not external to the test component that can restart the kubelet in the middle of the update configuration.
There was a problem hiding this comment.
I'm thinking if there were other uses like when kubelet paniced or something. I don't remember any tests explicitly stopping kubelet. But I saw supressed panics before (#101719).
I tend to ok this change since panic is bad enough condition to make test grid red.
|
/test pull-kubernetes-node-kubelet-serial |
- CPU manager - Memory Manager - Topology Manager Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
cynepco3hahue
force-pushed
the
e2e_node_fixes_after_dynamic_confiuration
branch
from
bc5b20b
to
117141e
Compare
|
/test pull-kubernetes-node-kubelet-serial |
|
@cynepco3hahue: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@SergeyKanzhelev Thanks for the review. I answered the comment and tests passed, except one that failed because of some unrelated problem |
cynepco3hahue
changed the title
SergeyKanzhelev
approved these changes
Nov 8, 2021
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cynepco3hahue, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/kind bug
What this PR does / why we need it:
The PR should fix a number of tests that were broken after Dynamic Kubelet configuration removal.
Fixes:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: