-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edit of non-registered custom API types #106268
fix edit of non-registered custom API types #106268
Conversation
Welcome @philipatl! |
Hi @philipatl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/priority backlog
/triage accepted
@philipatl can you add a test-case as a followup to this?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipatl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@soltysh Thanks, I have created a PR with a unit test here #106532 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes bug: kubectl edit of a type from an API extension server does not check preconditions.
The bug is, as a user if I
kubectl edit
a custom API resource (for example, a Fischer from the sample-apiserver), I can change the name in the metadata and I do not get aerror: At least one of apiVersion, kind and name was changed
.Instead, a Patch to the new user-edited name is created, which can result in NotFound or even making changes to the wrong object.
Slack discussion here: https://kubernetes.slack.com/archives/C0EG7JC6T/p1636403383157400?thread_ts=1636073009.129000&cid=C0EG7JC6T
Which issue(s) this PR fixes:
Fixes #106277
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: