Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Bump cAdvisor to v0.43.0 #106282

Merged
merged 2 commits into from
Nov 10, 2021
Merged

vendor: Bump cAdvisor to v0.43.0 #106282

merged 2 commits into from
Nov 10, 2021

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Nov 9, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Bump cAdvisor to v0.43.0.

Changes: google/cadvisor@v0.39.2...v0.43.0

and cAdvisor release notes have PRs included: https://github.com/google/cadvisor/releases

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 9, 2021
@k8s-ci-robot
Copy link
Contributor

@bobbypage: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 9, 2021
@bobbypage bobbypage mentioned this pull request Nov 9, 2021
Closed
@k8s-ci-robot k8s-ci-robot requested review from liggitt, logicalhan and a team November 9, 2021 22:34
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2021
@bobbypage
Bump cAdvisor to v0.43.0
c6452be 
Bumping cAdvisor from v0.39.2 -> v0.43.0

* Also pin transitive dependencies
  * containerd v1.4.9 -> v1.4.11
  * docker v20.10.2+incompatible> v20.10.7+incompatible

Signed-off-by: David Porter <david@porter.me>
@bobbypage
kubelet: update cAdvisor usage for v0.43
b6269ce 
* Change cAdvisor manager constructor
* Change call to adding AcceleratorUsageMetrics

Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 10, 2021
@bobbypage bobbypage changed the title [WIP] Bump cAdvisor to v0.43.0 Bump cAdvisor to v0.43.0 Nov 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@bobbypage bobbypage changed the title Bump cAdvisor to v0.43.0 vendor: Bump cAdvisor to v0.43.0 Nov 10, 2021
@bobbypage
Copy link
Member Author

/kind bug
/sig node

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 10, 2021
@bobbypage
Copy link
Member Author

/assign @dims
/cc @SergeyKanzhelev

dims
dims reviewed Nov 10, 2021
View reviewed changes
vendor/modules.txt
github.com/containerd/containerd/api/services/containers/v1
github.com/containerd/containerd/api/services/tasks/v1
github.com/containerd/containerd/api/services/version/v1
github.com/containerd/containerd/api/types
github.com/containerd/containerd/api/types/task
github.com/containerd/containerd/containers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice set of cleanups! yay. the rest of github.com/containerd/containerd will get cleaned out when we remove dockershim for sure. (or the change in moby/moby we are waiting on)

dims
dims approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@bobbypage
Copy link
Member Author

/assign @liggitt

@bobbypage
Copy link
Member Author

/cc @mrunalp @rphillips @harche @kolyshkin

harche
harche approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@harche harche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if any of bug fixes worth mentioning in release notes for k8s. I see it was like this without release notes most of the time

/lgtm

@liggitt
Copy link
Member

liggitt commented Nov 10, 2021

/approve

for deps

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dims, harche, liggitt, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit b56dc43 into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@PushkarJ PushkarJ mentioned this pull request Nov 10, 2021
Closed
@ehashman ehashman mentioned this pull request Nov 11, 2021
Closed
@judexzhu judexzhu mentioned this pull request Nov 12, 2021
Closed
@vsxen
Copy link

vsxen commented Nov 24, 2021

backport to v1.20? @bobbypage

containerd/containerd#4541
google/cadvisor#2956

@pacoxu pacoxu mentioned this pull request Dec 2, 2021
Closed
@pacoxu
Copy link
Member

pacoxu commented Dec 2, 2021

backport to v1.20? @bobbypage

containerd/containerd#4541 google/cadvisor#2956

@dims @liggitt @SergeyKanzhelev Should this be backported to 1.19-1.22 as the bump included bug fixes for metrics?

@bobbypage
Copy link
Member Author

google/cadvisor#2956 actually ended up being reverted in cAdvisor google/cadvisor#2964

@ml- ml- mentioned this pull request Dec 30, 2021
Closed
@lbogdan lbogdan mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@harche harche harche approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@logicalhan logicalhan Awaiting requested review from logicalhan

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@dims dims

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bobbypage @k8s-ci-robot @liggitt @vsxen @pacoxu @dims @SergeyKanzhelev @harche