-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append node e2e logs to file where possible #106362
Conversation
Functionality added in systemd 240: https://github.com/systemd/systemd/blob/1977d1477f635057a87c0a5a59fc5d4e0b8ed6ec/NEWS#L3919-L3921
@ehashman: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, endocrimes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
❤️ |
Functionality added in systemd 240:
https://github.com/systemd/systemd/blob/1977d1477f635057a87c0a5a59fc5d4e0b8ed6ec/NEWS#L3919-L3921
What type of PR is this?
/kind cleanup
/sig node
What this PR does / why we need it:
If the version of systemd supports it, appends to the kubelet log file rather than writing directly to it. This ensures that if the kubelet is restarted during the node e2e tests, we keep all the logs from that run prior to restart. This is especially important for serial tests which may have multiple restarts.
I tested this locally using the command
and saw that logs were present reflecting two kubelet starts.
Which issue(s) this PR fixes:
Fixes #106359 (comment)
Special notes for your reviewer:
/assign @aojea
/cc @endocrimes
I'm sorry that the code here would literally look better if written in Perl
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: